Generate the cycling style in the integration test - #39
Open
biodranik wants to merge 1 commit into
Open
Conversation
biodranik
force-pushed
the
ab/cycling-style
branch
from
August 15, 2026 07:52
9b34d53 to
acd56ad
Compare
biodranik
force-pushed
the
ab/cycling-style
branch
from
August 16, 2026 14:55
acd56ad to
4dddf9b
Compare
strump
approved these changes
Aug 17, 2026
The main repo gained a fourth style family, so full_drules_gen.py covered 6 of its 8 style variants. Derive the style/variant matrix from a tuple instead of spelling out every path: the layout is uniform, and the hardcoded dict was what made adding a family easy to forget. Vehicle stays last, as every style overwrites visibility.txt and classificator.txt in the data dir and the apps ship the ones the vehicle style produces. Generated with LLM assistance. Signed-off-by: Alexander Borsuk <me@alex.bio>
biodranik
force-pushed
the
ab/cycling-style
branch
from
August 20, 2026 10:22
4dddf9b to
0172cf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should be merged together with organicmaps/organicmaps#13330
The main repo gained a fourth style family (
cycling), sofull_drules_gen.pycovered 6 of its 8 style variants.The style/variant matrix is now derived from a tuple instead of spelling out every path — the layout is uniform, and the hardcoded dict was what made adding a family easy to forget.
vehiclestays last: every style rewritesvisibility.txtandclassificator.txtin the data dir, and the apps ship the ones the vehicle style produces.README updated (6 → 8 themes).
Testing
generates all 8 variants, exit 0.
ruff checkclean,python -m unittest discover -s testspasses 57/57.Generated with LLM assistance.