Skip to content

Fix underscore slash command autocomplete#1351

Open
huntharo wants to merge 1 commit into
overtake:masterfrom
huntharo:codex/fix-issue-1350-command-underscore
Open

Fix underscore slash command autocomplete#1351
huntharo wants to merge 1 commit into
overtake:masterfrom
huntharo:codex/fix-issue-1350-command-underscore

Conversation

@huntharo

@huntharo huntharo commented Mar 7, 2026

Copy link
Copy Markdown

Summary

  • allow _ while parsing slash-command autocomplete queries
  • add regression tests for command autocomplete parsing in FoundationUtils
  • keep autocomplete open for commands like /foo_bar

Testing

  • swift test in packages/FoundationUtils
  • manual verification in the macOS app: typing _ in a slash command no longer closes autocomplete

Screenshots

Before After
image image

Fixes #1350

@CLAassistant

CLAassistant commented Mar 7, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@huntharo

huntharo commented Apr 2, 2026

Copy link
Copy Markdown
Author

Oh, it looks like this got released for me:

image

@ghost

ghost commented Apr 6, 2026

Copy link
Copy Markdown

Thank you, i implemented it without accepting pull request. I think its already in release versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

macOS slash command autocomplete closes on '_' even though underscores are valid bot command characters

3 participants