Skip to content

editor: unify walkthrough + viewer UI, crouch, screenshot pause #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wass08 merged 8 commits into from
Jul 21, 2026
Merged

editor: unify walkthrough + viewer UI, crouch, screenshot pause #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
03a3c38
feat(walkthrough): unify first-person and baked walkthrough UI into a…
wass08 Jul 21, 2026
b7b749c
feat(viewer-ui): shared ViewerControlsBar + ViewerSceneHeader for pre…
wass08 Jul 21, 2026
8b44ad1
feat(walkthrough): hold-Ctrl crouch + P screenshot pause in both cont…
wass08 Jul 21, 2026
b0007d6
fix(walkthrough): crouched profile fits ~1 m openings
wass08 Jul 21, 2026
6c76fc0
feat(walkthrough): seamless screenshot pause — auto-release pointer l…
wass08 Jul 21, 2026
db76ee5
fix(walkthrough): screenshot pause is P again, advertised in the HUD
wass08 Jul 21, 2026
6996256
fix(walkthrough): freeze crouch during cursor pause; no editor hints …
wass08 Jul 21, 2026
cdbb5b1
chore: biome formatting + pre-existing useOptionalChain fix in wall p…
wass08 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
377 changes: 273 additions & 104 deletions packages/editor/src/components/editor/first-person-controls.tsx
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions packages/editor/src/components/ui/helpers/helper-manager.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,7 @@ function useActiveModifierKeys(): ActiveModifierKeys {
export function HelperManager() {
const mode = useEditor((s) => s.mode)
const tool = useEditor((s) => s.tool)
const isFirstPersonMode = useEditor((s) => s.isFirstPersonMode)
const measurementToolKind = useEditor((s) => s.toolDefaults.measurement?.kind)
const workspaceMode = useEditor((s) => s.workspaceMode)
const scope = useInteractionScope((s) => s.scope)
Expand Down Expand Up @@ -148,6 +149,10 @@ export function HelperManager() {
// Helpers are keyboard-driven hints (Esc, R, etc.) — irrelevant on touch.
if (isMobile) return null

// First-person walkthrough has its own HUD; editor shortcut hints (e.g. the
// Ctrl multi-select hint — Ctrl is crouch there) don't apply while walking.
if (isFirstPersonMode) return null

// The studio workspace (compose panel / gallery) has no scene selection or
// tools — editor shortcut hints would only mislead there.
if (workspaceMode === 'studio') return null
Expand Down
Loading
Loading