Skip to content

chore: replace web-dev-server with cem serve#3129

Open
bennypowers wants to merge 4 commits intostaging/pfv6from
chore/cem-serve
Open

chore: replace web-dev-server with cem serve#3129
bennypowers wants to merge 4 commits intostaging/pfv6from
chore/cem-serve

Conversation

@bennypowers
Copy link
Copy Markdown
Member

No description provided.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 6, 2026

⚠️ No Changeset found

Latest commit: 8a4bfa3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

✅ Commitlint tests passed!

More Info
{
  "valid": true,
  "errors": [],
  "warnings": [],
  "input": "chore: replace web-dev-server with cem serve"
}

@github-actions github-actions Bot added the AT passed Automated testing has passed label May 6, 2026
@bennypowers bennypowers requested review from Copilot and zeroedin and removed request for zeroedin May 6, 2026 21:08
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates local development and Playwright’s non-CI web server from @web/dev-server to cem serve, consolidating/adjusting CEM configuration accordingly.

Changes:

  • Replace web-dev-server usage with cem serve for local dev (wireit dev) and for Playwright’s local webServer command.
  • Add a root .config/cem.yaml and adjust existing CEM config under elements/.
  • Update Playwright demo navigation URL construction and bump @pwrs/* tooling dependencies.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
web-dev-server.config.js Removed legacy WDS configuration (and its associated pre-run filesystem writes).
docs/demo/web-dev-server.demo.config.js Removed WDS demo server config formerly used by Playwright.
.config/cem.yaml Added root CEM config to support cem serve and demo discovery.
elements/.config/cem.yaml Removed sourceControlRootUrl (now provided by root config).
playwright.config.ts Switch Playwright’s local webServer command to cem serve.
tools/pfe-tools/test/playwright/PfeDemoPage.ts Update demo URL routing logic and simplify constructor signature.
tools/pfe-tools/package.json Bump @pwrs/mappa version used by pfe-tools.
package.json Switch wireit dev command to cem serve and bump @pwrs/cem / @pwrs/mappa (plus optional platform deps).
package-lock.json Lockfile updates for the above dependency changes (including license metadata changes).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/pfe-tools/test/playwright/PfeDemoPage.ts
Comment thread tools/pfe-tools/test/playwright/PfeDemoPage.ts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

Deploy Preview for patternfly-elements ready!

Name Link
🔨 Latest commit e9ea075
😎 Deploy Preview https://deploy-preview-3129--patternfly-elements.netlify.app/

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 7, 2026

SSR Test Run for e9ea075: Report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AT passed Automated testing has passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants