fix(teach): update of vellipse and fellipse - #594
Conversation
|
Thanks for tracking down the teach-panel ellipse update bug — the fix for wiring up One thing I noticed in the diff: the vell = self.vellipse(q, centre="ee", scale=0.5, add=False)→ vell = self.vellipse(q, centre="ee", add=False)
|
future was 162 commits behind main, 0 ahead, last touched 2026-06-14 -- a leftover from before RTB used a proper PR-based workflow, no longer part of how anything actually merges (confirmed by MVTB and bdsim, Peter's other actively-maintained repos, which have already dropped their own future branches entirely -- RTB was the outlier still carrying it). Third-party repos (swift, spatialgeometry) still use their own future branch as the live PR-merge target, set by their own owners -- not touched here, unrelated to RTB's now-dead one. - ci.yml: drop future from push/pull_request trigger branches - pull_request_template.md: stop telling contributors to target future - README.md: fix a stray image URL pointing at future/docs/figs/... -- would have 404'd once the branch was actually deleted PR #594 (open, targeting future) retargeted to main separately before this merges, so it isn't orphaned by the branch deletion.
534fda6 to
3a5f05d
Compare
|
Indeed, dropped the scale as it appeared to big in many cases (e.g. Panda or Puma560). |
11e890a to
ae0a8ec
Compare
petercorke
changed the title
|
|
b69923b to
a7c7a2a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #594 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 142 142
Lines 13938 13940 +2
=====================================
- Misses 13938 13940 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2 participants
Problem
When
robot.teach(..., vellipse=True)is used, moving a joint slider updates the robot visualization but leaves the velocity ellipse at its initial configuration.The teach-panel callback already attempts to update a stored velocity ellipse, but the ellipse created by
teach()is not assigned to that backend reference and the callback cannot update the ellipse when the joint sliders change.Changes
teach()as the teach-panel ellipse.fellipse=True.Rationale
The plotting backend already contains the update mechanism for teach-panel ellipses. Assigning the objects when they are created connects that mechanism to the ellipses displayed by
teach().Related issues
No related issue found.