Restrict dashEnableCharts to Enterprise AG Charts loading, auto-enable enableCharts, and support AG Charts license key#448
Draft
Restrict dashEnableCharts to Enterprise AG Charts loading, auto-enable enableCharts, and support AG Charts license key#448
dashEnableCharts to Enterprise AG Charts loading, auto-enable enableCharts, and support AG Charts license key#448Conversation
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/52b7100d-a8cf-4090-a27d-31f1888b72dd Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/52b7100d-a8cf-4090-a27d-31f1888b72dd Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AG Charts not working in 33.3.3
Add Apr 7, 2026
dashEnableCharts lazy module loading for AG Charts v33+ and guard enableCharts configuration
Collaborator
|
@copilot AG charts are currently only supported on Enterprise, we dont need another type. Please make it so that |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/b14d1d59-45d4-401b-a5e8-00e870e4eb19 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Author
Implemented in commit
Screenshot: https://github.com/user-attachments/assets/8c5a807b-8b99-4696-b7ed-8cd54b28d95d Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Add
Restrict Apr 7, 2026
dashEnableCharts lazy module loading for AG Charts v33+ and guard enableCharts configurationdashEnableCharts to Enterprise AG Charts loading and guard enableCharts configuration
Collaborator
|
@copilot When setting
Or should it be that we use |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/9132d0c3-36f5-4796-9b93-ded3b9090eae Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/9132d0c3-36f5-4796-9b93-ded3b9090eae Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Author
Implemented in commit
Screenshot: https://github.com/user-attachments/assets/8c5a807b-8b99-4696-b7ed-8cd54b28d95d Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Restrict
Restrict Apr 7, 2026
dashEnableCharts to Enterprise AG Charts loading and guard enableCharts configurationdashEnableCharts to Enterprise AG Charts loading and auto-enable enableCharts
Collaborator
|
@copilot When using an AG Chart enterprise license, it needs to import the license manager and set it, as here: https://www.ag-grid.com/react-data-grid/integrated-charts-installation/ Adjust accordingly, we will need a new prop, if not passed, we will assume that it is the same key as the AG Grid key. |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/2184805b-e07e-4f34-be09-4ffde6381db6 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Author
Implemented in commit Added AG Charts Enterprise license handling in the enterprise fragment by importing AG Charts Screenshot: https://github.com/user-attachments/assets/8c5a807b-8b99-4696-b7ed-8cd54b28d95d Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
Restrict
Restrict Apr 8, 2026
dashEnableCharts to Enterprise AG Charts loading and auto-enable enableChartsdashEnableCharts to Enterprise AG Charts loading, auto-enable enableCharts, and support AG Charts license key
Collaborator
|
@copilot Update the tests, they are failing. |
Collaborator
|
Try again |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/93decd17-5ce1-4fa7-b9a3-2f5a95be7f39 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Author
Fixed in commit The failures were caused by a frontend crash when Screenshot: https://github.com/user-attachments/assets/8c5a807b-8b99-4696-b7ed-8cd54b28d95d
Retried and resolved in commit Root cause was Screenshot: https://github.com/user-attachments/assets/8c5a807b-8b99-4696-b7ed-8cd54b28d95d Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Collaborator
|
@copilot revert the change you just made |
Agent-Logs-Url: https://github.com/plotly/dash-ag-grid/sessions/64ea87f5-adca-4637-9b91-d464859aacc0 Co-authored-by: BSd3v <82055130+BSd3v@users.noreply.github.com>
Author
Done — reverted in commit This undoes the last Screenshot: https://github.com/user-attachments/assets/8c5a807b-8b99-4696-b7ed-8cd54b28d95d Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
AnnMarieW
reviewed
May 5, 2026
| * Load enterprise AG Charts modules for integrated charts. | ||
| * true and "community" are equivalent and set dashGridOptions.enableCharts=true. | ||
| */ | ||
| dashEnableCharts: PropTypes.oneOf(['community', 'enterprise']), |
Collaborator
There was a problem hiding this comment.
this prop type doesn't make sense if it can actually be a boolean as well. How about:
dashEnableCharts: PropTypes.oneOfType([
PropTypes.bool,
PropTypes.oneOf(['community', 'enterprise']),
]),
Should there be a default set as well?
Collaborator
There was a problem hiding this comment.
It can't be. The string just wasn't updated.
Collaborator
There was a problem hiding this comment.
How about renaming dashEnableCharts to something like chartMode. It's confusing to have both enableCharts and dashEnableCharts
AnnMarieW
reviewed
May 5, 2026
| until(lambda: dash_duo.find_element('#loaded').text == 'true', 10) | ||
|
|
||
| assert any( | ||
| "enableCharts is set, but chart modules are not loaded." |
Collaborator
There was a problem hiding this comment.
This error message is not very helpful. Shouldn't it be something like:
"enableCharts=true requires enableEnterpriseModules=true"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AG Grid v33+ requires explicit integrated chart module registration;
enableChartsalone now fails with AG Grid error #200. This change adds explicit Dash-side chart module loading control and clear misconfiguration guardrails, with Enterprise-only chart support.API surface (new props)
dashEnableChartstoAgGridwith supported values:trueor"enterprise": load enterprise integrated chartsfalse(default): do not load chart modulesdashEnableChartsis only valid whenenableEnterpriseModules=True.dashEnableChartsis set, the component now automatically setsdashGridOptions.enableCharts=true.chartsLicenseKeyfor AG Charts Enterprise licensing.licenseKey.Enterprise-only chart module registration
IntegratedChartsModule.with(AgChartsEnterpriseModule)dashEnableCharts="enterprise", AG Charts EnterpriseLicenseManageris now initialized withchartsLicenseKey(orlicenseKeyfallback).Misconfiguration protection
dashGridOptions.enableChartsis set withoutdashEnableCharts, the component throws a focused error explaining required enterprise settings.dashEnableChartsis used whileenableEnterpriseModules=False, the component throws a focused enterprise-only error.dashEnableChartsis combined withdashGridOptions.enableCharts=False, the component throws a focused conflict error.dashEnableChartsis excluded from forwarded AG Grid options to avoid unknown-option warnings.Focused coverage
dashEnableCharts=TruedashEnableCharts="enterprise"dashEnableCharts+dashGridOptions.enableCharts=FalsechartsLicenseKeywith enterprise chart configurationWarning
AG Charts support in Dash AG Grid is now enforced as Enterprise-only in this implementation.