Refactor cdc_2phase_clearable clock domains#318
Open
phsauter wants to merge 6 commits into
Open
Conversation
phsauter
force-pushed
the
phsauter/cdc-clearable-domain-split
branch
2 times, most recently
from
e3d6dae to
b1ea05c
Compare
phsauter
force-pushed
the
phsauter/cdc-clearable-domain-split
branch
from
b1ea05c to
61705f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #317, second part of the split #304.
Refactor the
cdc_2phase_clearableusing the new tests to check correctness, the goal was to cleanly separate it into a source and destination side and only have the async wires going between them in the top-level.Once #37 is merged this one should look more reasonable/scoped.