Skip to content

make: Fix slink_reg.sv target#25

Merged
fischeti merged 3 commits into
mainfrom
fix-make
Jun 25, 2026
Merged

make: Fix slink_reg.sv target#25
fischeti merged 3 commits into
mainfrom
fix-make

Conversation

@colluca

@colluca colluca commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

If $(SLINK_ROOT)/src/regs/slink_reg.sv is deleted but $(SLINK_ROOT)/src/regs/slink_reg_pkg.sv is not, the prior won't be rebuilt.

This is exactly what happens in Gwaihir. The target is more correctly written as suggested, albeit as a consequence it runs twice.

The only solution to both problems would be to use "Grouped Targets", but these have only been introduced since Make 4.3.

Comment thread slink.mk Outdated
Comment thread slink.mk Outdated

@fischeti fischeti left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM now. The CI is failing because of some spurious issues with the environment, but this should be fixed if you rebase onto main.

@fischeti fischeti merged commit 82b1f79 into main Jun 25, 2026
14 of 15 checks passed
@fischeti fischeti deleted the fix-make branch June 25, 2026 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants