Conversation
1 task
fischeti
reviewed
Jun 24, 2026
fischeti
reviewed
Jun 24, 2026
fischeti
approved these changes
Jun 25, 2026
fischeti
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! LGTM now. The CI is failing because of some spurious issues with the environment, but this should be fixed if you rebase onto main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
$(SLINK_ROOT)/src/regs/slink_reg.svis deleted but$(SLINK_ROOT)/src/regs/slink_reg_pkg.svis not, the prior won't be rebuilt.This is exactly what happens in Gwaihir. The target is more correctly written as suggested, albeit as a consequence it runs twice.
The only solution to both problems would be to use "Grouped Targets", but these have only been introduced since Make 4.3.