Skip to content

Content review: content/docs/iac/concepts/inputs-outputs/all.md - #20618

Open
pulumi-bot wants to merge 1 commit into
masterfrom
content-review/docs-iac-concepts-inputs-outputs-all
Open

Content review: content/docs/iac/concepts/inputs-outputs/all.md#20618
pulumi-bot wants to merge 1 commit into
masterfrom
content-review/docs-iac-concepts-inputs-outputs-all

Conversation

@pulumi-bot

@pulumi-bot pulumi-bot commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Important

This PR is set to auto-merge (squash). Once it has an approving review and the required build check passes, GitHub will merge it automatically — approving this PR will merge it. To prevent that, disable auto-merge (or convert the PR back to a draft) before approving.

Why this page

  • Page: content/docs/iac/concepts/inputs-outputs/all.md/docs/iac/concepts/inputs-outputs/all/
  • Lane: priority
  • Strategic tier: 1 (no_retire: true)
  • Traffic: 1,168 monthly visits (period 2026-01-27 to 2026-07-27; source CLICKSTREAM.FCT_PAGEVIEWS)
  • Last reviewed: never (attempts: 0)
  • Selection score: 29.178

This section is composed deterministically from the selection queue; do not edit it.

Fixes applied

No pre-stubbed candidates: .verified-claims.json returned 0 contradicted/mismatch verdicts and no Vale finding carried deterministic_fix: true. The fixes below are redirected internal links found during the review — every one resolves today only via an aliases: entry on the destination page, so each is a de-aliasing to the canonical full path with no change in destination.

Claim / finding Authoritative source Correction
L19 — [apply](/docs/concepts/inputs-outputs/apply/) is an alias path, not the canonical URL content/docs/iac/concepts/inputs-outputs/apply.md declares /docs/concepts/inputs-outputs/apply/ under aliases:; its canonical rendered_url is /docs/iac/concepts/inputs-outputs/apply/ Link retargeted to /docs/iac/concepts/inputs-outputs/apply/
L31 — same alias path for the second apply link same as above Link retargeted to /docs/iac/concepts/inputs-outputs/apply/
L171 — [Using output helpers](/docs/concepts/inputs-outputs/helpers/) is an alias path content/docs/iac/concepts/inputs-outputs/helpers.md declares /docs/concepts/inputs-outputs/helpers/ under aliases: Link retargeted to /docs/iac/concepts/inputs-outputs/helpers/
L171 — [stack output](/docs/using-pulumi/stack-outputs-and-references/) is an alias path; no page owns that URL directly content/tutorials/stack-outputs-refs-aws/index.md declares /docs/using-pulumi/stack-outputs-and-references/ under aliases: (this page was its only remaining inbound reference) Link retargeted to the canonical /tutorials/stack-outputs-refs-aws/ — the same destination the redirect already served

Findings not applied

  • Vale narrative voice (L33): “To demonstrate, let’s say you have created a server resource…” — not stamped deterministic_fix; recasting the sentence into imperative second person means authoring new prose (“Suppose you have created…” vs. restructuring the whole scenario setup), which is a judgment call, not a substitution.
  • Vale wordiness (L175): “In addition to strings, the all function can also be used…” — nag only, and the phrase is doing real work here (it links this section back to the preceding “Creating a new string” section); the sentence also carries a redundant “In addition … also” that a human may want to collapse. Left for an editorial pass.
  • Vale directional reference (L180): “you can see this demonstrated in the example below” — the target is the immediately following chooser block on the same page, which has no heading and therefore no anchor to link to. Fixing this properly means adding a heading or rewording, both judgment-level.
  • Go example return type (L96–102, flagged not fixed) — the ApplyT callback is declared as func (args []interface{}) pulumi.StringOutput, i.e. it returns an Output from inside ApplyT rather than a plain string, so connectionString would be an output-of-output. Claim c11 verified only at medium confidence (the SDK doc comment it was checked against uses the same shape), and correcting it means rewriting the snippet's signature and body — above the high-confidence bar. Worth a human look.

For the judgment-level items above, run /glow-up content/docs/iac/concepts/inputs-outputs/all.md.

Screenshot check

No images. The page source references no screenshots, diagrams, or other content images (only the generic shared meta_image card, if any), so there is nothing to verify. (Determined from the source; the screenshot pass was skipped.)

Rendered content

Ran (make buildpublic/docs/iac/concepts/inputs-outputs/all/index.html). Two content-bearing shortcodes on this page:

  • pulumi-apply — renders only the per-language spelling of the apply method name (apply / Apply). No checkable factual residue.
  • example-program path="aws-s3bucket-bucketobject-interpolate" — injects the six-language interpolation program from static/programs/aws-s3bucket-bucketobject-interpolate/. Residue claims checked: TypeScript pulumi.concat / pulumi.interpolate, Python Output.concat / Output.format, Go pulumi.Sprintf, C# Output.Format, Java Output.format, and the YAML ${...} interpolation — all are current, correctly named helpers, consistent with the surrounding prose ("build an S3 URL from bucket output values using each language's interpolation helper") and with Using output helpers. The Go tab pins pulumi-aws/sdk/v7, matching the checked-in program. No residue findings; no shared-source (shortcode/partial/data) edits made, so nothing here is multi-page.

Environment note: this checkout needed yarn install (root + theme/ + theme/stencil/) and node scripts/build-icon-sprite.js before make build would get as far as Hugo, and the full build then reported errors on unrelated pages elsewhere in the corpus. The reviewed page itself rendered cleanly, which is what this pass inspects.

Verification

  • make lint: ✅ make lint re-verified by the workflow on 141416756b
  • Pre-step artifacts:
    • .verified-claims.json: 27 verdict(s); 0 contradicted/mismatch, 0 unverifiable
    • .vale-findings.json: 3 finding(s)
    • .readthrough-findings.json: ran=True, 0 finding(s)
    • .frontmatter-validation.json: 1 file(s); 0 alias collision(s)

Automated existing-content review.

Co-Authored-By: Claude <noreply@anthropic.com>
@pulumi-bot
pulumi-bot enabled auto-merge (squash) July 31, 2026 16:09
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:docs PR touches technical docs and removed review:triaging Claude Triage is currently classifying the PR labels Jul 31, 2026
@pulumi-bot

Copy link
Copy Markdown
Collaborator Author

@github-actions github-actions Bot added review:in-progress Claude review is currently running review:error Workflow failed before publishing a review; see Actions logs and removed review:in-progress Claude review is currently running labels Jul 31, 2026
@CamSoper

Copy link
Copy Markdown
Contributor

@claude #new-review

@github-actions github-actions Bot added review:in-progress Claude review is currently running and removed review:error Workflow failed before publishing a review; see Actions logs labels Jul 31, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Pre-merge Review — Last updated 2026-07-31T18:35:54Z

Tip

Summary: This is an automated content-review PR touching one docs page, content/docs/iac/concepts/inputs-outputs/all.md, and it changes only three inline link targets — no prose edits. Two of the three are straightforward path modernizations (/docs/concepts/inputs-outputs/apply//docs/iac/concepts/inputs-outputs/apply/, and the same for helpers/) and both destinations exist. The third is a different kind of change: the "stack output" link moves from a docs concept page to an AWS-specific tutorial, which sends a reader looking for the general stack-outputs concept into a cloud-specific walkthrough and diverges from how the sibling apply.md links the same term. That's the one thing here that would leave a reader worse off than before. Passes run: link-target existence checks against the repo, a frontmatter/alias sweep, external claim verification on the three extracted claims, and a cross-sibling read of all three peers in inputs-outputs/. No Hugo build ran (content-only PR) and there were no code blocks or style findings to review.

Review confidence:

Dimension Level Notes
mechanics HIGH Diff is three link targets; all three destinations confirmed to exist in the repo.
facts HIGH
cross-sibling consistency HIGH All 3 peers in inputs-outputs/ read; one divergence found and reported.
Investigation log
  • Cross-sibling reads: 3 of 3 siblings
  • External claim verification: 3 of 3 claims verified (0 unverifiable, 0 contradicted) · 4 specialists (numerical, cross-reference, capability, framing); 0 cross-specialist corroborations · routed: 0 inline, 3 Pass 1, 0 Pass 2, 0 Pass 3.
  • Cited-claim spot-checks: not run (no cited claims)
  • Frontmatter sweep: ran on body + meta_desc
  • Temporal-trigger sweep: ran (recency words present in diff; spot-check in-review)
  • Code execution: not run (no static/programs/ change)
  • Code-examples checks: not run (no fenced code blocks in content files)
  • Editorial-balance pass: not run (not under content/blog/)
🚨 Outstanding ⚠️ Low-confidence 💡 Pre-existing ✅ Resolved
1 0 0 0

🔍 Verification trail

3 claims extracted · 3 verified · 0 unverifiable · 0 contradicted
  • L19 in content/docs/iac/concepts/inputs-outputs/all.md "The all function waits for all output values to become available and then provides them as plain values to the apply function." → ✅ verified (evidence: apply.md states: "The apply method solves this by waiting for the output value to become available and then executing a function with that plain value," and its info note explains all is used to combine multiple outputs before calling…; source: repo:content/docs/iac/concepts/inputs-outputs/apply.md)
  • L31 in content/docs/iac/concepts/inputs-outputs/all.md "Outputs that return to the engine as strings cannot be used directly in operations such as string concatenation until the output value has returned to Pulumi." → ✅ verified (evidence: The identical sentence appears verbatim as the canonical explanation on the linked target page content/docs/iac/concepts/inputs-outputs/apply.md: "Outputs that return to the engine as strings cannot be used directly in operations such as s…; source: repo:content/docs/iac/concepts/inputs-outputs/apply.md (line 477))
  • L171 in content/docs/iac/concepts/inputs-outputs/all.md "String interpolation can be used to export a stack output, and the relevant documentation for this is located at /tutorials/stack-outputs-refs-aws/." → ✅ verified (evidence: The repo pulumi/docs contains content/tutorials/stack-outputs-refs-aws/index.md, which resolves to /tutorials/stack-outputs-refs-aws/ — a tutorial titled around "Reference AWS Resources Across Stacks" covering stack outputs, matching the l…; source: gh api repos/pulumi/docs/contents/content/tutorials/stack-outputs-refs-aws)
  • L171 in content/docs/iac/concepts/inputs-outputs/all.md "the stack output link now points at the AWS tutorial /tutorials/stack-outputs-refs-aws/ rather than the stack-outputs concept section" → ⚔️ mismatch (evidence: the sibling page apply.md links the same term twice — at its lines 40 and 688 — to /docs/iac/concepts/stacks/#outputs, and content/docs/iac/concepts/stacks.md does define that anchor via the heading ## Stack outputs {#outputs}; source: repo:content/docs/iac/concepts/inputs-outputs/apply.md, repo:content/docs/iac/concepts/stacks.md)

🚨 Outstanding in this PR

These must be resolved or refuted before merging.

  • [L171] content/docs/iac/concepts/inputs-outputs/all.md — the "stack output" link is retargeted to an AWS-specific tutorial. The old target (/docs/using-pulumi/stack-outputs-and-references/) is indeed dead — no page or alias in the repo claims that URL — so it was right to change it. But /tutorials/stack-outputs-refs-aws/ is a cloud-specific walkthrough ("Reference AWS Resources Across Stacks"), and this sentence is generic prose in a language-and-cloud-neutral concept page. A reader following "stack output" from here wants the concept, not an AWS tutorial. The canonical target is /docs/iac/concepts/stacks/#outputs — the anchor defined by ## Stack outputs {#outputs} in content/docs/iac/concepts/stacks.md, and the exact link the sibling apply.md uses for this same term in both places it appears. Retarget it to match:

    You can use string interpolation to do things like export a [stack output](/docs/iac/concepts/stacks/#outputs) or provide a dynamically computed string as a new resource argument. For a full reference of the interpolation helpers available in each language, see [Using output helpers](/docs/iac/concepts/inputs-outputs/helpers/).
    

⚠️ Low-confidence

No low-confidence findings.

💡 Pre-existing issues in touched files (optional)

No pre-existing issues in touched files.

✅ Resolved since last review

No items resolved since the last review.

📜 Review history

  • 2026-07-31T18:35:54Z — Two apply/helpers path modernizations verified good; flagged the third link, where "stack output" was retargeted to an AWS tutorial instead of the /docs/iac/concepts/stacks/#outputs concept anchor that the sibling apply.md uses. (1414167)

  • Refresh this review — comment @claude #update-review. Say what you fixed, or which finding you dispute and why; both work in the same mention.
  • Ask for anything else — comment @claude with no hashtag (questions, one-off fixes). Leaves this review untouched.

Important

Please don't hide, resolve, or delete this comment! It breaks things!

📖 How pre-merge review works — the full lifecycle, short-circuits, and escape hatches.

@github-actions

Copy link
Copy Markdown
Contributor

🤖 Review regenerated on @CamSoper's request.

@github-actions github-actions Bot added review:outstanding-issues Claude review completed; outstanding has author-actionable findings and removed review:in-progress Claude review is currently running labels Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:docs PR touches technical docs review:outstanding-issues Claude review completed; outstanding has author-actionable findings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants