test: cover pluggy.__version__ getattr and HookCaller._remove_plugin … - #718
Open
darrenhuai wants to merge 1 commit into
Open
test: cover pluggy.__version__ getattr and HookCaller._remove_plugin …#718darrenhuai wants to merge 1 commit into
darrenhuai wants to merge 1 commit into
Conversation
…not-found path Ran the suite under coverage.py and found two real gaps in otherwise near-100% covered code. The module-level __getattr__ that lazily resolves pluggy.__version__ via importlib.metadata (added per changelog/590.trivial.rst) had no test exercising either branch. And HookCaller._remove_plugin's ValueError, raised when asked to remove a plugin that never registered on that hook, was untested even though the normal removal path is well covered through PluginManager.unregister.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…not-found path
Ran the suite under coverage.py and found two real gaps in otherwise near-100% covered code. The module-level getattr that lazily resolves pluggy.version via importlib.metadata (added per changelog/590.trivial.rst) had no test exercising either branch. And HookCaller._remove_plugin's ValueError, raised when asked to remove a plugin that never registered on that hook, was untested even though the normal removal path is well covered through
PluginManager.unregister.