Fix parse_types with metadata=True - #170
Merged
Merged
Conversation
RazerM
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 96.33% 96.35% +0.01%
==========================================
Files 7 7
Lines 1147 1152 +5
Branches 129 129
==========================================
+ Hits 1105 1110 +5
Misses 25 25
Partials 17 17 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
RazerM
force-pushed
the
feature/parse-types-metadata
branch
2 times, most recently
from
August 23, 2026 13:09
ee7af28 to
c12a639
Compare
With metadata=true, Space-Track wraps the rows in a dict alongside the request metadata, and _parse_types crashed iterating the dict's keys after the request had already succeeded. Unwrap the rows and leave the response shape unchanged.
RazerM
force-pushed
the
feature/parse-types-metadata
branch
from
August 23, 2026 13:45
c12a639 to
ea421f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With metadata=true, Space-Track wraps the rows in a dict alongside the
request metadata, and _parse_types crashed iterating the dict's keys
after the request had already succeeded. Unwrap the rows and leave the
response shape unchanged.