gh-148663: Document that IllegalMonthError inherits from both ValueError and IndexError#148664
Conversation
|
58e98ba to
1781682
Compare
|
@picnixz Thanks for taking a look! I've added the |
…alueError and IndexError
1781682 to
c4e2753
Compare
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
@picnixz Thanks very much for reviewing! What's the next step towards getting this merged? :) |
|
I need to come back home so a week or so. In general, once it is approved by one core dev, if the change is minimal, it will be merged when they have time. On your side there is nothing to do (we will ourselves update the branch if necessary/ |
|
There are however some lint issues so could you fix them please? |
Co-authored-by: Stan Ulbrych <stan@python.org>
|
Thanks @EoinTrial for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
|
GH-148917 is a backport of this pull request to the 3.14 branch. |
|
GH-148918 is a backport of this pull request to the 3.13 branch. |
|
Merged, GRMA! |
|
@StanFromIreland Tá fáilte mhór romhat, a chara ;) |
The documentation for
calendar.IllegalMonthErrordescribes it only as "a subclass ofValueError", but the source code defines it as:The
IndexErrorbase class is intentional for backwards compatibility (see the source comment inLib/calendar.py), but this is not mentioned in the docs. Users catchingIndexErrorfor bad month numbers won't know their code still works after Python 3.13.calendar.IllegalMonthErrordocs omit IndexError base class #148663📚 Documentation preview 📚: https://cpython-previews--148664.org.readthedocs.build/