gh-131684: Ignore unittest.SkipTest in pkgutil.walk_packages#148926
Closed
RezSat wants to merge 1 commit intopython:mainfrom
Closed
gh-131684: Ignore unittest.SkipTest in pkgutil.walk_packages#148926RezSat wants to merge 1 commit intopython:mainfrom
RezSat wants to merge 1 commit intopython:mainfrom
Conversation
|
All commit authors signed the Contributor License Agreement. |
Member
|
Closing for now because I do not think it is correct. Skipping side-effects (caused by the test package) because a root was not specified is IMO not the correct solution, rather it is right to not silently skip the exception. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-131684.
pkgutil.walk_packages() currently ignores ImportError by default but still
propagates unittest.SkipTest raised during package imports when no onerror
callback is provided.
This change makes walk_packages() ignore unittest.SkipTest by default in
that case so iteration can continue.
Also added a regression test in Lib/test/test_pkgutil.py and a NEWS entry.