Skip to content

Add C++ unit tests for cadence::fully_connected.out (#19165)#19165

Open
hsharma35 wants to merge 2 commits intopytorch:mainfrom
hsharma35:export-D97889888
Open

Add C++ unit tests for cadence::fully_connected.out (#19165)#19165
hsharma35 wants to merge 2 commits intopytorch:mainfrom
hsharma35:export-D97889888

Conversation

@hsharma35
Copy link
Copy Markdown
Contributor

@hsharma35 hsharma35 commented Apr 27, 2026

Summary:

Adds C++ unit tests for cadence::fully_connected.out in test_op_fully_connected.cpp. Tests verify correct dense layer output (y = Wx + b) across various input sizes, output feature counts, and with and without bias.

Reviewed By: zonglinpeng, mcremon-meta

Differential Revision: D97889888

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19165

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 3 Cancelled Jobs, 4 Pending, 2 Unrelated Failures

As of commit 3f3d684 with merge base 9207001 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 27, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 27, 2026

@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97889888.

@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented Apr 27, 2026

@hsharma35 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D97889888.

@hsharma35 hsharma35 requested a review from mcremon-meta April 27, 2026 20:24
@github-actions
Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…d_conv1d_nlc.out (pytorch#19161)

Summary:

Adds C++ unit tests for cadence::quantized_conv1d_ncl.out and cadence::quantized_conv1d_nlc.out in test_op_quantized_conv1d_ncl.cpp. Also modifies op_quantized_conv1d_ncl.cpp and op_quantized_conv1d_nlc.cpp in the HiFi backend to fix correctness issues surfaced by the new tests.

Reviewed By: mcremon-meta, zonglinpeng

Differential Revision: D97886683
Summary:

Adds C++ unit tests for cadence::fully_connected.out in test_op_fully_connected.cpp. Tests verify correct dense layer output (y = Wx + b) across various input sizes, output feature counts, and with and without bias.

Reviewed By: zonglinpeng, mcremon-meta

Differential Revision: D97889888
@meta-codesync meta-codesync Bot changed the title Add C++ unit tests for cadence::fully_connected.out Add C++ unit tests for cadence::fully_connected.out (#19165) Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants