Fix argument to EngineProcessor.get_sampler in example notebook#8091
Fix argument to EngineProcessor.get_sampler in example notebook#8091guygordonZ wants to merge 1 commit into
Conversation
Replaced run_name syntax with: device_config_revision=cirq_google.engine.processor_config.Run(run_name)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8091 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 1110 1110
Lines 100561 100561
=======================================
Hits 100175 100175
Misses 386 386 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| " # Get these values from an internal partner:\n", | ||
| " # device_config_name='layout_42',\n", | ||
| " # run_name='2023.11.06-1.0',\n", | ||
| " # device_config_revision=cirq_google.engine.processor_config.Run(run_name)',\n", |
There was a problem hiding this comment.
| " # device_config_revision=cirq_google.engine.processor_config.Run(run_name)',\n", | |
| " # device_config_revision=cirq_google.engine.processor_config.Run(run_name),\n", |
pavoljuhas
left a comment
There was a problem hiding this comment.
LGTM with a cleanup of leftover quote.
As of #7672
EngineProcessor.get_samplerdoes not accept therun_nameargument. Use
device_config_revisioninstead.Fixes b/515775786