Skip to content

Fix argument to EngineProcessor.get_sampler in example notebook#8091

Open
guygordonZ wants to merge 1 commit into
quantumlib:mainfrom
guygordonZ:patch-1
Open

Fix argument to EngineProcessor.get_sampler in example notebook#8091
guygordonZ wants to merge 1 commit into
quantumlib:mainfrom
guygordonZ:patch-1

Conversation

@guygordonZ

@guygordonZ guygordonZ commented May 22, 2026

Copy link
Copy Markdown

As of #7672 EngineProcessor.get_sampler does not accept the run_name
argument. Use device_config_revision instead.

Fixes b/515775786

Replaced run_name syntax with: device_config_revision=cirq_google.engine.processor_config.Run(run_name)
@guygordonZ guygordonZ requested review from a team, hoisinberg, verult and wcourtney as code owners May 22, 2026 21:27
@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-cla

google-cla Bot commented May 22, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions Bot added the Size: XS <10 lines changed label May 22, 2026
@codecov

codecov Bot commented May 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.61%. Comparing base (f4c35b0) to head (c520417).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8091   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files        1110     1110           
  Lines      100561   100561           
=======================================
  Hits       100175   100175           
  Misses        386      386           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

" # Get these values from an internal partner:\n",
" # device_config_name='layout_42',\n",
" # run_name='2023.11.06-1.0',\n",
" # device_config_revision=cirq_google.engine.processor_config.Run(run_name)',\n",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
" # device_config_revision=cirq_google.engine.processor_config.Run(run_name)',\n",
" # device_config_revision=cirq_google.engine.processor_config.Run(run_name),\n",

@pavoljuhas pavoljuhas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a cleanup of leftover quote.

@pavoljuhas pavoljuhas changed the title Replaced run_name syntax per bug: 515775786 Fix argument to EngineProcessor.get_sampler in example notebook May 26, 2026
@pavoljuhas pavoljuhas added the ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. label May 26, 2026
@pavoljuhas pavoljuhas added the priority/before-1.7 Finish before the Cirq 1.7 release label Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/no-release Use this label for pull request that should not have Cirq pre-release on PyPI. priority/before-1.7 Finish before the Cirq 1.7 release Size: XS <10 lines changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants