Skip to content

Make DD more stable - #8130

Merged
NoureldinYosri merged 9 commits into
mainfrom
dd
Jun 13, 2026
Merged

Make DD more stable#8130
NoureldinYosri merged 9 commits into
mainfrom
dd

Conversation

@NoureldinYosri

@NoureldinYosri NoureldinYosri commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Avoid error in add_dynamical_decoupling when PhasedXZGate differs
from a Clifford gate by small numerical round-off.

@NoureldinYosri
NoureldinYosri requested a review from a team as a code owner June 10, 2026 21:09
@github-actions github-actions Bot added the size: S 10< lines changed <50 label Jun 10, 2026
@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.60%. Comparing base (6922063) to head (52acf72).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8130   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files        1118     1118           
  Lines      101003   101029   +26     
=======================================
+ Hits       100603   100629   +26     
  Misses        400      400           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliottrosenberg eliottrosenberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @NoureldinYosri!

@pavoljuhas pavoljuhas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let us not add an extra tol argument if not used. Also please see inline for a couple of more tweaks.

Otherwise LGTM.

Comment thread cirq-core/cirq/ops/phased_x_z_gate.py Outdated
Comment thread cirq-core/cirq/ops/phased_x_z_gate.py Outdated
Comment thread cirq-core/cirq/ops/phased_x_z_gate_test.py Outdated
Comment thread cirq-core/cirq/ops/phased_x_z_gate_test.py Outdated
Comment thread cirq-core/cirq/transformers/dynamical_decoupling.py Outdated
NoureldinYosri and others added 2 commits June 11, 2026 14:06
Co-authored-by: Pavol Juhas <juhas@google.com>
Co-authored-by: Pavol Juhas <juhas@google.com>
@github-actions github-actions Bot added size: M 50< lines changed <250 and removed size: S 10< lines changed <50 labels Jun 11, 2026
NoureldinYosri and others added 2 commits June 11, 2026 14:07
Co-authored-by: Pavol Juhas <juhas@google.com>
Co-authored-by: Pavol Juhas <juhas@google.com>
@github-actions github-actions Bot added size: S 10< lines changed <50 and removed size: M 50< lines changed <250 labels Jun 13, 2026
@NoureldinYosri
NoureldinYosri added this pull request to the merge queue Jun 13, 2026
Merged via the queue into main with commit 780fe1f Jun 13, 2026
52 checks passed
@NoureldinYosri
NoureldinYosri deleted the dd branch June 13, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: S 10< lines changed <50

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants