Make DD more stable - #8130
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8130 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 1118 1118
Lines 101003 101029 +26
=======================================
+ Hits 100603 100629 +26
Misses 400 400 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
eliottrosenberg
approved these changes
Jun 10, 2026
eliottrosenberg
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Thanks, @NoureldinYosri!
pavoljuhas
requested changes
Jun 11, 2026
pavoljuhas
left a comment
Collaborator
There was a problem hiding this comment.
Let us not add an extra tol argument if not used. Also please see inline for a couple of more tweaks.
Otherwise LGTM.
Co-authored-by: Pavol Juhas <juhas@google.com>
Co-authored-by: Pavol Juhas <juhas@google.com>
Co-authored-by: Pavol Juhas <juhas@google.com>
Co-authored-by: Pavol Juhas <juhas@google.com>
pavoljuhas
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid error in
add_dynamical_decouplingwhenPhasedXZGatediffersfrom a Clifford gate by small numerical round-off.