localize dates according to document lang in NL, DE and EN (default)#150
Open
gronke wants to merge 5 commits into
Open
localize dates according to document lang in NL, DE and EN (default)#150gronke wants to merge 5 commits into
gronke wants to merge 5 commits into
Conversation
syrosh
previously approved these changes
Jun 5, 2025
PeterMosmans
requested changes
Sep 25, 2025
PeterMosmans
left a comment
PeterMosmans
left a comment
Contributor
There was a problem hiding this comment.
Currently, as it stands, this errors out if there's no date (yet) set:
Error at char 36 in xsl:value-of/@select on line 321 column 106 of meta.xslt:
XPST0008 Variable date has not been declared (or its declaration is not in scope)
I'm thinking of whether we can support a default (?) language as fallback, in order to ensure backwards compatibility?
Use @Date attribute instead of undeclared $date variable in version history, and use the -tbd variant to handle missing dates gracefully. Default lang parameter to 'en' when xml:lang is not set.
gronke
force-pushed
the
feat/localized-dates
branch
from
d0b6d9d to
683be03
Compare
Contributor
Author
@PeterMosmans does 683be03 solve this? Could you test again? |
Contributor
|
Thanks for the changes, will re-check |
Contributor
|
It looks like something goes wrong with parsing version info in the document properties - the dates are now full timestamps: Tested with different |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Localizes dates in Dutch, German and English (default) with custom functions.
Hardcoding the month names helps to avoid fiddling with Saxon and Java.