Change crop struct to match height for 16 by 9 mode. Addresses #7321#7328
Open
sandyol55 wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
Open
Change crop struct to match height for 16 by 9 mode. Addresses #7321#7328sandyol55 wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
sandyol55 wants to merge 1 commit intoraspberrypi:rpi-6.12.yfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed correction to the struct definition of the full resolution 16:9 cropped modes to reflect the actual cropped height.
Tested and resolves both the issue of offset and distorted ScalerCrop images in Picamera2, and the crop definitions returned by rpi-cam apps --list-cameras.