Skip to content

fix: prevent programmatic scrolls from cancelling active touches on iOS #57546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tjzel wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: prevent programmatic scrolls from cancelling active touches on iOS #57546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a1b49ec
fix: prevent programmatic scrolls from cancelling active touches on iOS
tjzel Jul 14, 2026
8723cea
chore: cxx api snapshots
tjzel Jul 15, 2026
ef05bac
fix: other scroll events
tjzel Aug 18, 2026
61ad7c7
Merge branch 'main' into fix/ios-responder-ignore-programmatic-scroll
tjzel Aug 18, 2026
66b4a87
fix: type
tjzel Aug 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...eact-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ - (BOOL)_shouldDisableScrollInteraction
metrics.containerSize = RCTSizeFromCGSize(_scrollView.bounds.size);
metrics.zoomScale = _scrollView.zoomScale;
metrics.timestamp = CACurrentMediaTime();
metrics.responderIgnoreScroll = !_isUserTriggeredScrolling;

if (_layoutMetrics.layoutDirection == LayoutDirection::RightToLeft) {
metrics.contentOffset.x = metrics.contentSize.width - metrics.containerSize.width - metrics.contentOffset.x;
Expand Down
4 changes: 3 additions & 1 deletion .../react-native/React/Fabric/Mounting/ComponentViews/TextInput/RCTTextInputComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,9 @@ - (void)textInputDidChangeSelection
- (void)scrollViewDidScroll:(UIScrollView *)scrollView
{
if (_eventEmitter) {
static_cast<const TextInputEventEmitter &>(*_eventEmitter).onScroll([self _textInputMetrics]);
auto metrics = [self _textInputMetrics];
metrics.responderIgnoreScroll = !(scrollView.isDragging || scrollView.isDecelerating);
static_cast<const TextInputEventEmitter &>(*_eventEmitter).onScroll(metrics);
}
}

Expand Down
4 changes: 3 additions & 1 deletion packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollEvent.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ jsi::Value ScrollEvent::asJSIValue(jsi::Runtime& runtime) const {

payload.setProperty(runtime, "zoomScale", zoomScale);
payload.setProperty(runtime, "timestamp", timestamp * 1000);
payload.setProperty(runtime, "responderIgnoreScroll", responderIgnoreScroll);

return payload;
}
Expand All @@ -67,7 +68,8 @@ folly::dynamic ScrollEvent::asDynamic() const {
"contentInset", std::move(contentInsetObj))(
"contentSize", std::move(contentSizeObj))(
"layoutMeasurement", std::move(containerSizeObj))(
"zoomScale", zoomScale)("timestamp", timestamp * 1000);
"zoomScale", zoomScale)("timestamp", timestamp * 1000)(
"responderIgnoreScroll", responderIgnoreScroll);

return metrics;
};
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/renderer/components/scrollview/ScrollEvent.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ struct ScrollEvent : public EventPayload {
EdgeInsets contentInset;
Size containerSize;
Float zoomScale{};
bool responderIgnoreScroll{false};

/*
* The time in seconds when the touch occurred or when it was last mutated.
Expand Down
3 changes: 3 additions & 0 deletions ...es/react-native/ReactCommon/react/renderer/components/textinput/TextInputEventEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,9 @@ static jsi::Value textInputMetricsScrollPayload(
"zoomScale",
textInputMetrics.zoomScale != 0.0f ? textInputMetrics.zoomScale : 1);

payload.setProperty(
runtime, "responderIgnoreScroll", textInputMetrics.responderIgnoreScroll);

return payload;
};

Expand Down
1 change: 1 addition & 0 deletions ...ages/react-native/ReactCommon/react/renderer/components/textinput/TextInputEventEmitter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class TextInputEventEmitter : public ViewEventEmitter {
int eventCount;
Size layoutMeasurement;
Float zoomScale;
bool responderIgnoreScroll{false};
Tag target;
};

Expand Down
1 change: 1 addition & 0 deletions packages/react-native/types_DEPRECATED/Libraries/Components/TextInput/TextInput.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@ export type TextInputFocusEvent = NativeSyntheticEvent<TextInputFocusEventData>;
*/
export interface TextInputScrollEventData {
contentOffset: {x: number; y: number};
responderIgnoreScroll?: boolean | undefined;
}

/**
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5070,6 +5070,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {
}

struct facebook::react::TextInputEventEmitter::Metrics {
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float zoomScale;
Expand Down Expand Up @@ -7901,6 +7902,7 @@ struct facebook::react::ScrollEndDragEvent : public facebook::react::ScrollEvent

struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float timestamp;
public facebook::react::Float zoomScale;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4881,6 +4881,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {
}

struct facebook::react::TextInputEventEmitter::Metrics {
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float zoomScale;
Expand Down Expand Up @@ -7662,6 +7663,7 @@ struct facebook::react::ScrollEndDragEvent : public facebook::react::ScrollEvent

struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float timestamp;
public facebook::react::Float zoomScale;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5061,6 +5061,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {
}

struct facebook::react::TextInputEventEmitter::Metrics {
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float zoomScale;
Expand Down Expand Up @@ -7892,6 +7893,7 @@ struct facebook::react::ScrollEndDragEvent : public facebook::react::ScrollEvent

struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float timestamp;
public facebook::react::Float zoomScale;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7244,6 +7244,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {
}

struct facebook::react::TextInputEventEmitter::Metrics {
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float zoomScale;
Expand Down Expand Up @@ -9920,6 +9921,7 @@ struct facebook::react::ScrollEndDragEvent : public facebook::react::ScrollEvent

struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float timestamp;
public facebook::react::Float zoomScale;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7087,6 +7087,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {
}

struct facebook::react::TextInputEventEmitter::Metrics {
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float zoomScale;
Expand Down Expand Up @@ -9737,6 +9738,7 @@ struct facebook::react::ScrollEndDragEvent : public facebook::react::ScrollEvent

struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float timestamp;
public facebook::react::Float zoomScale;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7235,6 +7235,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {
}

struct facebook::react::TextInputEventEmitter::Metrics {
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float zoomScale;
Expand Down Expand Up @@ -9911,6 +9912,7 @@ struct facebook::react::ScrollEndDragEvent : public facebook::react::ScrollEvent

struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Float timestamp;
public facebook::react::Float zoomScale;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3561,6 +3561,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {

struct facebook::react::TextInputEventEmitter::Metrics {
public Float zoomScale;
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Point contentOffset;
Expand Down Expand Up @@ -6022,6 +6023,7 @@ struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public Float timestamp;
public Float zoomScale;
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Point contentOffset;
public facebook::react::Size containerSize;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3412,6 +3412,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {

struct facebook::react::TextInputEventEmitter::Metrics {
public Float zoomScale;
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Point contentOffset;
Expand Down Expand Up @@ -5847,6 +5848,7 @@ struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public Float timestamp;
public Float zoomScale;
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Point contentOffset;
public facebook::react::Size containerSize;
Expand Down
2 changes: 2 additions & 0 deletions scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3552,6 +3552,7 @@ struct facebook::react::TextInputEventEmitter::KeyPressMetrics {

struct facebook::react::TextInputEventEmitter::Metrics {
public Float zoomScale;
public bool responderIgnoreScroll;
public facebook::react::AttributedString::Range selectionRange;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Point contentOffset;
Expand Down Expand Up @@ -6013,6 +6014,7 @@ struct facebook::react::ScrollEvent : public facebook::react::EventPayload {
public Float timestamp;
public Float zoomScale;
public ScrollEvent() = default;
public bool responderIgnoreScroll;
public facebook::react::EdgeInsets contentInset;
public facebook::react::Point contentOffset;
public facebook::react::Size containerSize;
Expand Down
Loading