Fix ResizeObserver SwiftPM iOS builds - #58010
Closed
cipolleschi wants to merge 1 commit into
Closed
Conversation
|
@cipolleschi has imported this pull request. If you are a Meta employee, you can view this in D116607687. |
|
@cipolleschi merged this pull request in 8c64de2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Commit
b03652af789b5e2d0d31554dc61230cd4ad9964dadded the ResizeObserver implementation to theReact-FabricSwiftPM target, but did not exclude its C++ test directory.SwiftPM therefore recursively treated
ReactCommon/react/renderer/observers/resize/tests/ResizeObserverTest.cppas a production framework source. All iOS, iOS Simulator, and Mac Catalyst prebuilt-core slices failed while compiling it because GoogleTest is not a dependency of the productionReact-Fabrictarget:This adds
observers/resize/teststo the target's existing test exclusions, matching the treatment of the other React-Fabric test directories and leaving the dedicated C++ test target unchanged.Changelog:
[INTERNAL] [FIXED] - Exclude ResizeObserver C++ tests from the React-Fabric SwiftPM production target.
Test Plan:
prebuild_react_native_corejobs from run32239670611; each failed compilingResizeObserverTest.cppdue to the missinggtest/gtest.hheader.git diff --checkswift package --disable-sandbox dump-packageand verified that theReact-Fabrictarget excludesobservers/resize/tests.xcodebuildwas attempted, but this environment prevents SwiftPM'ssandbox-execfrom running before dependency resolution; CI will exercise the original failing build path.