Expose InspectorNetworkReporter integration point to Frameworks (Android) - #58012
Closed
huntie wants to merge 1 commit into
Closed
Expose InspectorNetworkReporter integration point to Frameworks (Android)#58012huntie wants to merge 1 commit into
huntie wants to merge 1 commit into
Conversation
…oid) Summary: **Motivation** Third-party networking stacks that replace React Native's networking modules have no supported way to report CDP and Web Performance network events, so their requests are invisible in the React Native DevTools Network panel. **This diff** On Android, the `InspectorNetworkReporter` integration point (our intended public API) is closed — change `InspectorNetworkReporter`'s visibility to `public`, and annotate with`UnstableReactNativeAPI`. On iOS no visibility change is needed — `RCTInspectorNetworkReporter` already ships via `React-Core`. **🚧 Unstable API** These APIs are exposed, but marked with `UnstableReactNativeAPI` (on Android) until we consolidate their use by an external integrator (Expo). This leaves open the potential for minor changes, although unlikely. **Changes** - `InspectorNetworkReporter` is now `public`, annotated `UnstableReactNativeAPI`, requiring explicit opt-in. `NetworkEventUtil` and `WebSocketModule` opt in via `Silvochka:OptIn`. - `react/networking/` joins the prefab header export in `build.gradle.kts`, matching iOS's `React-networking` pod parity. - Doc comments on `NetworkReporter`, `RCTInspectorNetworkReporter` and `InspectorNetworkReporter` drop `[Experimental]`, naming each as the third-party integration point. Changelog: [Android][Added] - **Network Inspection**: Expose network event reporting to third-party networking stacks as an unstable API Differential Revision: D116472113
meta-cla
Bot
added
the
CLA Signed
|
@huntie has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116472113. |
|
This pull request has been merged in 83d0be8. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Motivation
Third-party networking stacks that replace React Native's networking modules have no supported way to report CDP and Web Performance network events, so their requests are invisible in the React Native DevTools Network panel.
This diff
On Android, the
InspectorNetworkReporterintegration point (our intended public API) is closed — changeInspectorNetworkReporter's visibility topublic, and annotate withUnstableReactNativeAPI.On iOS no visibility change is needed —
RCTInspectorNetworkReporteralready ships viaReact-Core.🚧 Unstable API
These APIs are exposed, but marked with
UnstableReactNativeAPI(on Android) until we consolidate their use by an external integrator (Expo). This leaves open the potential for minor changes, although unlikely.Changes
InspectorNetworkReporteris nowpublic, annotatedUnstableReactNativeAPI, requiring explicit opt-in.NetworkEventUtilandWebSocketModuleopt in viaSilvochka:OptIn.react/networking/joins the prefab header export inbuild.gradle.kts, matching iOS'sReact-networkingpod parity.NetworkReporter,RCTInspectorNetworkReporterandInspectorNetworkReporterdrop[Experimental], naming each as the third-party integration point.Changelog:
[Android][Added] - Network Inspection: Expose network event reporting to third-party networking stacks as an unstable API
Differential Revision: D116472113