Move ReactPerfettoCategories to its own submodule (#58024) - #58024
Open
j-piasecki wants to merge 1 commit into
Open
Move ReactPerfettoCategories to its own submodule (#58024)#58024j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116626009. |
Summary: Changelog: [Internal] Under the C++ Stable API RFC, `cxxreact:tracesection` is classified as "for frameworks", while transitively exposing a header from `reactperflogger:reactperflogger`, classified as "private". To avoid this issue, this diff moves that header (`ReactPerfettoCategories.h`) to a separate module - `reactperflogger:perfettocategories`, and classifies it as "for frameworks". Differential Revision: D116626009
meta-codesync
Bot
changed the title
j-piasecki
force-pushed
the
export-D116626009
branch
from
August 21, 2026 10:34
4fe9a2e to
6918b3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Changelog: [Internal]
Under the C++ Stable API RFC,
cxxreact:tracesectionis classified as "for frameworks", while transitively exposing a header fromreactperflogger:reactperflogger, classified as "private".To avoid this issue, this diff moves that header (
ReactPerfettoCategories.h) to a separate module -reactperflogger:perfettocategories, and classifies it as "for frameworks".Differential Revision: D116626009