Cover react/timing:timing with Stable API guards (#58026) - #58026
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover react/timing:timing with Stable API guards (#58026)#58026j-piasecki wants to merge 1 commit into
react/timing:timing with Stable API guards (#58026)#58026j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116769152. |
facebook-github-tools
Bot
added
p: Software Mansion
meta-codesync
Bot
changed the title
react/timing:timing with Stable API guardsreact/timing:timing with Stable API guards (#58026)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 21, 2026
Summary: Classifies `react/timing:timing` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/Timing.h` as its public entry point. Wires into all the environments that need it: the guard dependency and the umbrella glob in BUCK, `react_cxxstableapi` in CMake, a `React-cxxstableapi` dependency plus a `timingUmbrella` subspec in the podspec, a header-staging entry for the iOS prebuild, and a prefab export for Android. SwiftPM needs no change. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/Timing.h>` umbrella header as the public entry point for `react/timing` Differential Revision: D116769152
j-piasecki
force-pushed
the
export-D116769152
branch
from
August 21, 2026 08:40
cf9bd19 to
3edca09
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 21, 2026
Summary: Classifies `react/timing:timing` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/Timing.h` as its public entry point. Wires into all the environments that need it: the guard dependency and the umbrella glob in BUCK, `react_cxxstableapi` in CMake, a `React-cxxstableapi` dependency plus a `timingUmbrella` subspec in the podspec, a header-staging entry for the iOS prebuild, and a prefab export for Android. SwiftPM needs no change. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/Timing.h>` umbrella header as the public entry point for `react/timing` Differential Revision: D116769152
j-piasecki
force-pushed
the
export-D116769152
branch
from
August 21, 2026 11:00
3edca09 to
156a553
Compare
Summary: Classifies `react/timing:timing` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/Timing.h` as its public entry point. Wires into all the environments that need it: the guard dependency and the umbrella glob in BUCK, `react_cxxstableapi` in CMake, a `React-cxxstableapi` dependency plus a `timingUmbrella` subspec in the podspec, a header-staging entry for the iOS prebuild, and a prefab export for Android. SwiftPM needs no change. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/Timing.h>` umbrella header as the public entry point for `react/timing` Differential Revision: D116769152
j-piasecki
force-pushed
the
export-D116769152
branch
from
August 25, 2026 06:36
156a553 to
827411c
Compare
|
This pull request has been merged in 70f172d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/timing:timingas a public target under the C++ stable API three-tier visibility model and introduces the module umbrellaReact/Timing.has its public entry point.Wires into all the environments that need it: the guard dependency and the umbrella glob in BUCK,
react_cxxstableapiin CMake, aReact-cxxstableapidependency plus atimingUmbrellasubspec in the podspec, a header-staging entry for the iOS prebuild, and a prefab export for Android. SwiftPM needs no change.The guards are inert unless a consumer defines
RN_STRICT_API, so there is no behavior change.Changelog:
[General][Added] - Add
<React/Timing.h>umbrella header as the public entry point forreact/timingDifferential Revision: D116769152