Cover react/featureflags with Stable API guards (#58083) - #58083
Open
j-piasecki wants to merge 1 commit into
Open
Cover react/featureflags with Stable API guards (#58083)#58083j-piasecki wants to merge 1 commit into
react/featureflags with Stable API guards (#58083)#58083j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117172757. |
meta-codesync
Bot
changed the title
react/featureflags with Stable API guardsreact/featureflags with Stable API guards (#58083)
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 25, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
August 25, 2026 06:37
f086688 to
4f5056f
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 25, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
August 25, 2026 06:37
4f5056f to
6187357
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 26, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
August 26, 2026 07:28
6187357 to
2031073
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 26, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
August 26, 2026 07:29
2031073 to
81ae7ea
Compare
cortinico
approved these changes
Aug 28, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 28, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Reviewed By: cortinico Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
August 28, 2026 12:58
81ae7ea to
b156fac
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 28, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Reviewed By: cortinico Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
2 times, most recently
from
August 28, 2026 12:59
6f49430 to
b156fac
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 28, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Reviewed By: cortinico Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
August 28, 2026 13:00
b156fac to
8eb2c8a
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Sep 1, 2026
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Reviewed By: cortinico Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
September 1, 2026 09:01
8eb2c8a to
5b1cfe9
Compare
Summary: Classifies `react/featureflags:featureflags` as a public target under the C++ stable API three-tier visibility model and introduces the module umbrella `React/FeatureFlags.h` as its public entry point. This module's headers are generated, so the `UmbrellaGuard.h` include is added to the templates in `scripts/featureflags/templates/common-cxx/` rather than to the headers themselves. `ReactNativeFeatureFlagsOverridesOSSStable.h` is the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers. The sibling `react/nativemodule/featureflags:featureflags` target is private under the same model. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [General][Added] - Add `<React/FeatureFlags.h>` umbrella header as the public entry point for `react/featureflags` Reviewed By: cortinico Differential Revision: D117172757
j-piasecki
force-pushed
the
export-D117172757
branch
from
September 3, 2026 08:16
5b1cfe9 to
179ff8e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/featureflags:featureflagsas a public target under the C++ stable API three-tier visibility model and introduces the module umbrellaReact/FeatureFlags.has its public entry point.This module's headers are generated, so the
UmbrellaGuard.hinclude is added to the templates inscripts/featureflags/templates/common-cxx/rather than to the headers themselves.ReactNativeFeatureFlagsOverridesOSSStable.his the module's one hand-written header and is edited directly. The umbrella is not generated, and re-exports all eight of the module's headers.The sibling
react/nativemodule/featureflags:featureflagstarget is private under the same model.The guards are inert unless a consumer defines
RN_STRICT_API, so there is no behavior change.Changelog:
[General][Added] - Add
<React/FeatureFlags.h>umbrella header as the public entry point forreact/featureflagsReviewed By: cortinico
Differential Revision: D117172757