Skip to content

Cover 'react/performance' subtree with C++ stable API guards (#58116) #58116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-piasecki wants to merge 1 commit into from
Closed

Cover 'react/performance' subtree with C++ stable API guards (#58116) #58116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ target_include_directories(react_performance_cdpmetrics PUBLIC ${REACT_COMMON_DI
target_link_libraries(react_performance_cdpmetrics
folly_runtime
jsi
react_cxxstableapi
react_performance_timeline
react_timing
runtimeexecutor)
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpInteractionTypes.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <string_view>
#include <unordered_map>

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpMetricsReporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <jsi/jsi.h>
#include <react/performance/timeline/PerformanceEntry.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/cdpmetrics/CdpPerfIssuesReporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <ReactCommon/RuntimeExecutor.h>
#include <jsi/jsi.h>
#include <react/performance/timeline/PerformanceEntry.h>
Expand Down
2 changes: 2 additions & 0 deletions ...react-native/ReactCommon/react/performance/cdpmetrics/React-performancecdpmetrics.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ Pod::Spec.new do |s|

resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_performancecdpmetrics")

s.dependency "React-cxxstableapi"

add_dependency(s, "React-runtimeexecutor", :additional_framework_paths => ["platform/ios"])
s.dependency "React-jsi"
s.dependency "React-performancetimeline"
Expand Down
1 change: 1 addition & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ target_link_libraries(react_performance_timeline
jsinspector
jsinspector_tracing
reactperflogger
react_cxxstableapi
react_featureflags
react_timing
folly_runtime)
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/CircularBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <algorithm>
#include <functional>
#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <react/timing/primitives.h>

#include <optional>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <vector>
#include "PerformanceEntry.h"

Expand Down
2 changes: 2 additions & 0 deletions ...ages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryCircularBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "CircularBuffer.h"
#include "PerformanceEntryBuffer.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryKeyedBuffer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <optional>
#include <unordered_map>
#include <vector>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceEntryReporter.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "PerformanceEntryCircularBuffer.h"
#include "PerformanceEntryKeyedBuffer.h"
#include "PerformanceEntryReporterListeners.h"
Expand Down
2 changes: 2 additions & 0 deletions ...s/react-native/ReactCommon/react/performance/timeline/PerformanceEntryReporterListeners.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "PerformanceEntry.h"

#include <folly/dynamic.h>
Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceObserver.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include "PerformanceEntryBuffer.h"
#include "PerformanceObserverRegistry.h"

Expand Down
2 changes: 2 additions & 0 deletions packages/react-native/ReactCommon/react/performance/timeline/PerformanceObserverRegistry.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@

#pragma once

#include <react/cxxstableapi/PrivateGuard.h>

#include <memory>
#include <mutex>
#include <set>
Expand Down
2 changes: 2 additions & 0 deletions ...ges/react-native/ReactCommon/react/performance/timeline/React-performancetimeline.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ Pod::Spec.new do |s|

resolve_use_frameworks(s, header_mappings_dir: "../../..", module_name: "React_performancetimeline")

s.dependency "React-cxxstableapi"

s.dependency "React-featureflags"
add_dependency(s, "React-jsinspector", :framework_name => 'jsinspector_modern')
add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing')
Expand Down
Loading