Cover react/nativemodule/defaults:defaults with Stable API guards - #58118
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover react/nativemodule/defaults:defaults with Stable API guards#58118j-piasecki wants to merge 1 commit into
react/nativemodule/defaults:defaults with Stable API guards#58118j-piasecki wants to merge 1 commit into
Conversation
Summary: Classifies `react/nativemodule/defaults` as a private target under the three-tier C++ stable API visibility model. `DefaultTurboModules.h` now includes `<react/cxxstableapi/PrivateGuard.h>`, and the module picks up a dependency on the guard target so the include resolves for every build. Changelog: [Internal] Differential Revision: D116287984
meta-cla
Bot
added
the
CLA Signed
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116287984. |
facebook-github-tools
Bot
added
p: Software Mansion
cortinico
approved these changes
Aug 25, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
|
This pull request has been merged in e988b12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/nativemodule/defaultsas a private target under the three-tier C++ stable API visibility model.DefaultTurboModules.hnow includes<react/cxxstableapi/PrivateGuard.h>, and the module picks up a dependency on the guard target so the include resolves for every build.Changelog: [Internal]
Differential Revision: D116287984