Cover the mutation observer modules with Stable API guards (#58126) - #58126
Closed
j-piasecki wants to merge 1 commit into
Closed
Cover the mutation observer modules with Stable API guards (#58126)#58126j-piasecki wants to merge 1 commit into
j-piasecki wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@j-piasecki has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117326015. |
meta-codesync
Bot
changed the title
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 26, 2026
Summary: Classifies `react/renderer/observers/mutation:mutation` and `react/nativemodule/mutationobserver:mutationobserver` as private targets under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include their headers directly; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Differential Revision: D117326015
j-piasecki
force-pushed
the
export-D117326015
branch
from
August 26, 2026 07:46
d975f0c to
e35280d
Compare
j-piasecki
added a commit
to j-piasecki/react-native
that referenced
this pull request
Aug 28, 2026
Summary: Classifies `react/renderer/observers/mutation:mutation` and `react/nativemodule/mutationobserver:mutationobserver` as private targets under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include their headers directly; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D117326015
j-piasecki
force-pushed
the
export-D117326015
branch
from
August 28, 2026 06:16
e35280d to
d0dd71b
Compare
Summary: Classifies `react/renderer/observers/mutation:mutation` and `react/nativemodule/mutationobserver:mutationobserver` as private targets under the three-tier C++ stable API visibility model. Consumers that opt into `RN_STRICT_API` now get an error if they include their headers directly; without that flag the guards are inert, so no existing build changes behaviour. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D117326015
j-piasecki
force-pushed
the
export-D117326015
branch
from
August 28, 2026 06:17
d0dd71b to
26eec36
Compare
|
This pull request has been merged in ac2f12b. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Classifies
react/renderer/observers/mutation:mutationandreact/nativemodule/mutationobserver:mutationobserveras private targets under the three-tier C++ stable API visibility model. Consumers that opt intoRN_STRICT_APInow get an error if they include their headers directly; without that flag the guards are inert, so no existing build changes behaviour.Changelog: [Internal]
Reviewed By: christophpurrer
Differential Revision: D117326015