Keep only release level on DefaultNewArchitectureEntryPoint (#58469) - #58469
Closed
christophpurrer wants to merge 1 commit into
Closed
Keep only release level on DefaultNewArchitectureEntryPoint (#58469)#58469christophpurrer wants to merge 1 commit into
christophpurrer wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@christophpurrer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D119370657. |
meta-codesync
Bot
changed the title
christophpurrer
force-pushed
the
export-D119370657
branch
from
September 10, 2026 21:11
51bcf26 to
25be70a
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 10, 2026
) Summary: TurboModules, Fabric and bridgeless are all unconditionally enabled in the New Architecture, so every remaining flag on `DefaultNewArchitectureEntryPoint` was dead configuration. Reduce it to the one thing it still selects: the release level. Removes the deprecated parameterized `load(...)` overloads, the `fabricEnabled`, `turboModulesEnabled` and `concurrentReactEnabled` getters, and `isConfigurationValid`. Call sites that passed `fabricEnabled` to `DefaultReactActivityDelegate` now use its two-argument constructor, which already ignored the flag. Changelog: [Android][Breaking] - Remove the deprecated `DefaultNewArchitectureEntryPoint.load(turboModulesEnabled, fabricEnabled)` overloads; use `load()` instead [Android][Breaking] - Remove `DefaultNewArchitectureEntryPoint.fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled` and `isConfigurationValid` Differential Revision: D119370657
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 10, 2026
) Summary: TurboModules, Fabric and bridgeless are all unconditionally enabled in the New Architecture, so every remaining flag on `DefaultNewArchitectureEntryPoint` was dead configuration. Reduce it to the one thing it still selects: the release level. Removes the deprecated parameterized `load(...)` overloads, the `fabricEnabled`, `turboModulesEnabled` and `concurrentReactEnabled` getters, and `isConfigurationValid`. Call sites that passed `fabricEnabled` to `DefaultReactActivityDelegate` now use its two-argument constructor, which already ignored the flag. Changelog: [Android][Breaking] - Remove the deprecated `DefaultNewArchitectureEntryPoint.load(turboModulesEnabled, fabricEnabled)` overloads; use `load()` instead [Android][Breaking] - Remove `DefaultNewArchitectureEntryPoint.fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled` and `isConfigurationValid` Differential Revision: D119370657
christophpurrer
force-pushed
the
export-D119370657
branch
from
September 10, 2026 21:11
25be70a to
cd881fe
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 10, 2026
) Summary: TurboModules, Fabric and bridgeless are all unconditionally enabled in the New Architecture, so every remaining flag on `DefaultNewArchitectureEntryPoint` was dead configuration. Reduce it to the one thing it still selects: the release level. Removes the deprecated parameterized `load(...)` overloads, the `fabricEnabled`, `turboModulesEnabled` and `concurrentReactEnabled` getters, and `isConfigurationValid`. Call sites that passed `fabricEnabled` to `DefaultReactActivityDelegate` now use its two-argument constructor, which already ignored the flag. Changelog: [Android][Breaking] - Remove the deprecated `DefaultNewArchitectureEntryPoint.load(turboModulesEnabled, fabricEnabled)` overloads; use `load()` instead [Android][Breaking] - Remove `DefaultNewArchitectureEntryPoint.fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled` and `isConfigurationValid` Differential Revision: D119370657
) Summary: TurboModules, Fabric and bridgeless are all unconditionally enabled in the New Architecture, so every remaining flag on `DefaultNewArchitectureEntryPoint` was dead configuration. Reduce it to the one thing it still selects: the release level. Removes the deprecated parameterized `load(...)` overloads, the `fabricEnabled`, `turboModulesEnabled` and `concurrentReactEnabled` getters, and `isConfigurationValid`. Call sites that passed `fabricEnabled` to `DefaultReactActivityDelegate` now use its two-argument constructor, which already ignored the flag. Changelog: [Android][Breaking] - Remove the deprecated `DefaultNewArchitectureEntryPoint.load(turboModulesEnabled, fabricEnabled)` overloads; use `load()` instead [Android][Breaking] - Remove `DefaultNewArchitectureEntryPoint.fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled` and `isConfigurationValid` Reviewed By: javache Differential Revision: D119370657
christophpurrer
force-pushed
the
export-D119370657
branch
from
September 11, 2026 14:47
cd881fe to
e822534
Compare
christophpurrer
added a commit
to christophpurrer/react-native-macos
that referenced
this pull request
Sep 11, 2026
) Summary: TurboModules, Fabric and bridgeless are all unconditionally enabled in the New Architecture, so every remaining flag on `DefaultNewArchitectureEntryPoint` was dead configuration. Reduce it to the one thing it still selects: the release level. Removes the deprecated parameterized `load(...)` overloads, the `fabricEnabled`, `turboModulesEnabled` and `concurrentReactEnabled` getters, and `isConfigurationValid`. Call sites that passed `fabricEnabled` to `DefaultReactActivityDelegate` now use its two-argument constructor, which already ignored the flag. Changelog: [Android][Breaking] - Remove the deprecated `DefaultNewArchitectureEntryPoint.load(turboModulesEnabled, fabricEnabled)` overloads; use `load()` instead [Android][Breaking] - Remove `DefaultNewArchitectureEntryPoint.fabricEnabled`, `turboModulesEnabled`, `concurrentReactEnabled` and `isConfigurationValid` Reviewed By: javache Differential Revision: D119370657
|
This pull request has been merged in ca2e11a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
TurboModules, Fabric and bridgeless are all unconditionally enabled in the New
Architecture, so every remaining flag on
DefaultNewArchitectureEntryPointwasdead configuration. Reduce it to the one thing it still selects: the release
level.
Removes the deprecated parameterized
load(...)overloads, thefabricEnabled,turboModulesEnabledandconcurrentReactEnabledgetters, andisConfigurationValid. Call sites that passedfabricEnabledtoDefaultReactActivityDelegatenow use its two-argument constructor, whichalready ignored the flag.
Changelog:
[Android][Breaking] - Remove the deprecated
DefaultNewArchitectureEntryPoint.load(turboModulesEnabled, fabricEnabled)overloads; useload()instead[Android][Breaking] - Remove
DefaultNewArchitectureEntryPoint.fabricEnabled,turboModulesEnabled,concurrentReactEnabledandisConfigurationValidReviewed By: javache
Differential Revision: D119370657