Conversation
… repo URLs Agent-Logs-Url: https://github.com/refined-github/octicons-plain-react/sessions/d00b1949-987c-4f58-8c9e-01e42ed5256e Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
fregante
changed the title
|
@SunsetTechuila new repo in the org! |
| with: | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - uses: actions/checkout@v6 | ||
| - uses: actions/setup-node@v6 |
There was a problem hiding this comment.
Mottie/github-reserved-names#31 (comment)
Still relevant
|
@copilot use node 22 in setup-node |
Agent-Logs-Url: https://github.com/refined-github/octicons-plain-react/sessions/90141f67-eb82-4040-8628-d0eac2a3da20 Co-authored-by: fregante <1402241+fregante@users.noreply.github.com>
| - uses: actions/setup-node@v6 | ||
| with: | ||
| registry-url: 'https://registry.npmjs.org' | ||
| node-version: '22' |
There was a problem hiding this comment.
I would use
| node-version: '22' | |
| node-version: lts/* |
There was a problem hiding this comment.
This is a temporary workaround, we should prefer setting the engine field. Here we can't set it because it would be a breaking change and we're just following the source package's versioning.
They're not too far behind though, so soon: https://github.com/primer/octicons/blob/711ef28bd38aecc89380c5183caa91014f85c8f8/.github/workflows/ci.yml#L15
There was a problem hiding this comment.
Actually ☝️🤓 we should prefer devEngines.runtime. I never suggested it because fnm still doesn't support it 😭: Schniz/fnm#1433
There was a problem hiding this comment.
You were right, this is just a publish step, it does not have to follow the project's node version, I just realized 😅
|
|
||
| if npm version "$(npm info @primer/octicons version)"; then | ||
| npm publish | ||
| npm publish --provenance |
There was a problem hiding this comment.
Weird. It all seems to be correctly configured but it's failing.
There was a problem hiding this comment.
Failure: https://github.com/refined-github/octicons-plain-react/actions/runs/25153190669/job/73728442462
Environment details
node: v22.22.2
npm: 10.9.7
yarn: 1.22.22
The same setup works in https://github.com/refined-github/github-url-detection/actions/workflows/npm-publish.yml
That repo:
node: v24.14.1
npm: 11.11.0
yarn: 1.22.22
There was a problem hiding this comment.
Note: Trusted publishing requires npm CLI version 11.5.1 or later and Node version 22.14.0 or higher.
There was a problem hiding this comment.
The action doesn't allow picking the npm version, so I went ahead and just used 24 like the docs suggest
id-token: writepermission for npm trusted publisher--provenanceflag tonpm publishactions/setup-node