Add ISO 8601 fallback for older Swift - #21
Open
TyceHerrman wants to merge 1 commit into
Open
Conversation
|
@remko Could you please check if this patch makes sense? |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Date.ISO8601Format()for Swift 6.2 and newerISO8601DateFormatter().string(from:)with older compilersSwift 5.10.1's Linux corelibs Foundation does not provide
Date.ISO8601Format(). The compiler guard keeps the current API on the supported Swift 6.2 path while allowing downstream legacy builds to use the portable formatter.Closes #20
Validation
DEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer makeDEVELOPER_DIR=/Applications/Xcode.app/Contents/Developer make test(105 tests)swift-formatlint overPackage.swift Sources Scripts Testsgit diff --checkaarch64-linuxandx86_64-linux, using this source without the downstream formatter substitutionAI disclosure: prepared with assistance from OpenAI Codex (GPT-5).