allow mutation of private record fields with @allowMutation#8366
Open
allow mutation of private record fields with @allowMutation#8366
@allowMutation#8366Conversation
3a8f357 to
2bcf3f7
Compare
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
should be reversed at some point to become the default behavior you could opt-out with `@DisallowMutation`
f33af2d to
12f8390
Compare
12f8390 to
57f0c88
Compare
zth
approved these changes
Apr 19, 2026
cristianoc
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR allows this:
Using private for records is very convenient to bind to JS classes so you can easily access properties and methods while preventing object creation. Though, before this PR, the mutation of fields marked as mutable inside private records was not possible and that is a common limitation inside WebAPI bindings, for
DOM.nodefor example wheretextContentshould be mutable.