Rewatch: improve watch output and add clear-screen#8373
Merged
Conversation
Make screen clearing opt-in so scripted stdout stays stable while interactive watch mode can drop stale warnings and errors between rebuilds. Also print explicit rebuild and failure markers so fixed vs broken state is easier to spot. Refs #8139 Signed-off-by: Paul Kim <paul.bushuo@gmail.com>
336ba68 to
7756388
Compare
Collaborator
Author
|
@codex review |
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
Signed-off-by: Paul Kim <paul.bushuo@gmail.com>
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
rolandpeelen
approved these changes
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CompilationOutcomerescript watch --clear-screenfor interactive watch mode--clear-screenonly runs for interactive watch output, so scripted and non-TTY stdout stays unchanged. Screen clearing usesconsole::Term::stdout().clear_screen()for better cross-platform terminal support.Closes #8139, #8161
Testing
cargo test --manifest-path rewatch/Cargo.toml