[ci] Allow selecting the cargo profile for Docker image builds - #5124
[ci] Allow selecting the cargo profile for Docker image builds#5124tillrohrmann wants to merge 1 commit into
Conversation
cd5bc5d to
c68accb
Compare
Allow reusable and manually dispatched Docker builds to select any Cargo profile, and propagate it through cargo-chef, compilation, artifact lookup, and local just builds. Handle Cargo's historical output directories for built-in profiles while preserving custom profile directories. Prefix non-release image tags so profile builds cannot overwrite regular release tags. Remove the redundant debug workflow input and use profile configuration as the source of debug settings. Parca builds still force debug information for the selected profile and retain the larger runner, timeout, and uncached build path.
c68accb to
72f5ebe
Compare
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 72f5ebef72
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| profile: | ||
| description: "cargo profile to build with (must exist in Cargo.toml)" | ||
| required: false | ||
| default: "release" | ||
| type: string |
There was a problem hiding this comment.
When an existing external caller passes with: debug: true, GitHub validates it against workflow_call.inputs, so replacing the declared input with only profile makes that workflow fail before this job starts. This workflow explicitly supports external repositories (.github/workflows/docker.yml:1-4), and the consumer documentation still advertises debug (docs/dev/build-and-ci.md:192-201); retain it as a deprecated compatibility alias for the corresponding profile, or provide a coordinated migration before removing it.
AGENTS.md reference: AGENTS.md:L51-L51
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
My hope would be that nobody is using this field. I am confirming with the cloud team.
2 participants
Allow reusable and manually dispatched Docker builds to select any Cargo profile, and propagate it through cargo-chef, compilation, artifact lookup, and local just builds.
Handle Cargo's historical output directories for built-in profiles while preserving custom profile directories. Prefix non-release image tags so profile builds cannot overwrite regular release tags.
Remove the redundant debug workflow input and use profile configuration as the source of debug settings. Parca builds still force debug information for the selected profile and retain the larger runner, timeout, and uncached build path.