Queue used to process server messages - #1
Draft
robsunday wants to merge 3 commits into
Draft
Conversation
robsunday
commented
Jul 27, 2026
|
|
||
| private static final Logger logger = | ||
| Logger.getLogger(ServerToAgentMessageHandler.class.getName()); | ||
| private static final int MAX_MESSAGE_QUEUE_SIZE = 5; |
Owner
Author
There was a problem hiding this comment.
[for reviewer] Just some max size to prevent memory errors in case processing hangs for some reason.
| * request. | ||
| */ | ||
| private void tryStart() { | ||
| public synchronized void requestStartProfiling() { |
Owner
Author
There was a problem hiding this comment.
[for reviewer] In the final solution requestStartProfiling() should be renamed to start(), requestStopProfiling() to stop() and requestReinitializeProfiling() to reinitialize(). I did not do it to avoid additional files to be modified, that would impact clarity of this draft
…ig-async-processing # Conflicts: # opamp/src/main/java/com/splunk/opentelemetry/opamp/OpampActivator.java # opamp/src/main/java/com/splunk/opentelemetry/opamp/ServerToAgentMessageHandler.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is illustration of the idea of async processing of all server messages.
Queue is used to store and process ServerToAgent messages. ProfilingSupervisor no longer use queue.
It is not a complete, fully working solution yet (there is some startup issue with Snapshot Profiler that I need to investigate)