Retry temp-dir deletes in test teardown to clear transient Windows locks - #375
Merged
Merged
Conversation
forceDeleteDir now retries the delete with a linear backoff (and is async, awaiting util.sleep between attempts) so a file handle an earlier test left open has time to close before the rmdir, instead of failing the build with ENOTEMPTY. It still logs the remaining paths and re-throws if every attempt fails. All call sites updated to await it.
TwitchBronBron
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #368. That PR added
forceDeleteDirto diagnose the intermittent Windows CI failure where a test's teardown couldn't delete the shared.tmpdir (ENOTEMPTY: directory not empty, rmdir ...). The diagnostics confirmed the cause: an earlier test leaves a file handle open, so Windows keeps the directory entry around until that handle closes.This makes
forceDeleteDirrecover from that instead of just reporting it:rmdir.util.sleepbetween attempts so pending handle-close callbacks can run during the wait; a synchronous wait would block the event loop and prevent the handle from closing. All call sites updated to await it.