Skip to content

[Feat] [SDK-399] Okhttp interceptor #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
buongarzoni wants to merge 20 commits into
base: master
Choose a base branch
from

fix(okhttp): replace java.util.function.Function with custom UrlSanit…

be12a54
Select commit
Loading
Failed to load commit list.
Open

[Feat] [SDK-399] Okhttp interceptor #367

fix(okhttp): replace java.util.function.Function with custom UrlSanit…
be12a54
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed May 2, 2026 in 11m 34s

Code review found 1 potential issue

Found 5 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit rollbar-okhttp/README.md:87-95 README opt-in example silently re-exposes credentials and fragments

Annotations

Check warning on line 95 in rollbar-okhttp/README.md

See this annotation in the file changed.

@claude claude / Claude Code Review

README opt-in example silently re-exposes credentials and fragments 

The opt-in example at README.md:91 uses `HttpUrl::toString` to re-enable the full URL, but the surrounding warning text at lines 87 and 95 only mentions "sensitive query parameters" — yet `HttpUrl::toString` simultaneously re-exposes userinfo (basic-auth credentials) and the fragment, which the Security paragraph at line 83 just promised the default strips. A reader whose URLs are query-param-clean but contain basic-auth credentials will follow the example and silently leak those credentials to
View more details on Claude