fix(cli): apply --deps.never-bundle by camel-casing dotted flag keys - #1058
Open
dylanpulver wants to merge 1 commit into
Open
fix(cli): apply --deps.never-bundle by camel-casing dotted flag keys#1058dylanpulver wants to merge 1 commit into
--deps.never-bundle by camel-casing dotted flag keys#1058dylanpulver wants to merge 1 commit into
Conversation
✅ Deploy Preview for tsdown-main ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
tsdown
create-tsdown
@tsdown/css
@tsdown/exe
tsdown-migrate
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI usage
Description
--deps.never-bundlehas been a no-op since thedepsnamespace rename (7f50966). cac'scamelcaseOptionNamecamel-cases only the first segment of a dotted option name, so the flag parses todeps['never-bundle']whileresolveDepsConfigreadsdeps.neverBundle. Nothing errors, because the command setsallowUnknownOptions.On
main, withleftpadpresent innode_modules:Renaming the option to
--deps.neverBundlewas the alternative. That leaves the kebab spelling silently doing nothing, and the kebab spelling is whatdocs/reference/cli.mdandskills/tsdown/references/document, so this normalizes the parsed keys and both spellings work.Normalization is scoped to
flags.depsat one level.--env.*is excluded since its keys are user-supplied variable names. A future dotted option in another namespace would need the same handling.src/cli.test.tsparses through the realcliinstance, which required exporting it. The first case fails onmain; the other two pin current behavior.Linked Issues
Additional context