Fix DKIM signing guide against Rspamd source#112
Open
moisseev wants to merge 2 commits into
Open
Conversation
All corrections verified against the rspamd source tree.
- rspamc DKIM tests were non-functional: `-d` is `--deliver` (not a
domain) and `-f` is `--flag` (fuzzy). Rewrote them to scan a real
message as an authenticated user (`-u`), whose `From:` header domain
must match; `-F` sets the SMTP envelope sender, not the MIME `From:`
DKIM signs (see upstream rspamd discussion #6129).
- Check the `DKIM_SIGNED` symbol instead of grepping the folded
`DKIM-Signature:` header, which matched only its first line; document
`rspamc -j | jq` to print the full signature.
- Drop fabricated/no-op options (`cache_key`, `cache_expiry`,
`server_keys`); replace `server_keys` with a correct per-host config.
- Move `selector_map` to the top level (ignored inside a domain block).
- Prefix the Vault token env var with `RSPAMD_` so the
`{= VAULT_DKIM_TOKEN =}` template resolves.
- Remove a broken/redundant automated test script, a duplicated `dig`
example, and the bogus `dkim_keygen -t` "validation".
- dkim-management.md: add the missing `dkim_keygen` options (`-o/--output`, `--priv-output`, `-f/--force`) and fix the `-s` default (`mail`, not `default`), per lualib/rspamadm/dkim_keygen.lua. - dkim_signing.md: `sign_condition` is supported by the `dkim_signing` module too (shared via lua_dkim_tools), not only by the `dkim` module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All corrections verified against the rspamd source tree.
-dis--deliver(not a domain) and-fis--flag(fuzzy). Rewrote them to scan a real message as an authenticated user (-u), whoseFrom:header domain must match;-Fsets the SMTP envelope sender, not the MIMEFrom:DKIM signs (see upstream rspamd discussion Rspamd dkim signing with Postfix... using virtual_alias_domains and virtual_aliases. rspamd#6129).DKIM_SIGNEDsymbol instead of grepping the foldedDKIM-Signature:header, which matched only its first line; documentrspamc -j | jqto print the full signature.cache_key,cache_expiry,server_keys); replaceserver_keyswith a correct per-host config.selector_mapto the top level (ignored inside a domain block).RSPAMD_so the{= VAULT_DKIM_TOKEN =}template resolves.digexample, and the bogusdkim_keygen -t"validation".