fix(toolbar): eliminate duplicate id in toolbar_input_select() - #1351
Merged
Conversation
The toolbar_input_select() function was creating duplicate element IDs
by assigning the same id to both the outer container div and the inner
select element. This violates HTML standards and can cause issues with
selectors and accessibility tools.
The fix assigns a distinct id to the select element using the pattern
{id}--select (double dash to avoid conflicts with Shiny module inputs),
while the container retains its id for the Shiny input binding. Updates
the label's for attribute accordingly.
Fixes #1350
gadenbuie
marked this pull request as ready for review
August 21, 2026 15:33
This comment was marked as resolved.
This comment was marked as resolved.
cpsievert
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1350
Summary
toolbar_input_select()was generating HTML with duplicateidattributes on both the container div and the inner select element. This violates HTML standards and can cause issues with JavaScript selectors and accessibility tools.The fix assigns a distinct ID to the select element using the pattern
{id}--select(double dash to avoid conflicts with Shiny module inputs), while the container retains its ID for Shiny's input binding system. The label'sforattribute is updated to point to the new select ID.Verification
Before the fix,
toolbar_input_select("select", label = "Choose", choices = c("A", "B"))produced:After the fix, it produces: