Fix ERB formatting#354
Merged
Merged
Conversation
# Conflicts: # spec/lib/rufo/erb_formatter_spec.rb
Two fixes for code that previously raised SyntaxError in ErbFormatter: - yield with multiple args / parens: Ripper.sexp returns nil for these at top level, so process_code fell through to determine_code_wrappers and then to raise_syntax_error!. raise_syntax_error! calls format_code expecting it to raise, but Rufo::Formatter handles yield via sexp_unparsable_code and instead returned a formatted string, which was then mis-assigned as `prefix` and produced corrupt input. Use Rufo::Parser.sexp_unparsable_code as the Ripper.sexp fallback so these forms skip the wrapper logic entirely. - `case EXPR` alone (split across ERB tags): none of the existing wrappers make a bare case header parse, since case requires a when clause. Add a `\nwhen nil\nend` suffix wrapper so the header tag is parseable in isolation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.