feat: add the worktree-done Makefile target - #41
Conversation
The worktree target creates an identity worktree; nothing removed one. The worktree-done target verifies a clean tree and a fully merged branch, then removes the worktree and deletes the branch. Landing the work includes this step. Co-Authored-By: Martin Zeman <N4M3Z@users.noreply.github.com>
|
@cursor review |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR adds a substantial worktree/workspace cleanup capability that can delete directories and local branches, relies on GitHub merge-state verification, and changes existing Jujutsu worktree behavior. Tests and ownership are strong positives, but the new multi-path logic and irreversible side effects merit human review. Notes:
You can add or adjust custom eligibility rules. Learn more. |
|
Failing step: Quality, Release notes attestation. Cause: The pull request body has no Release Notes section with a list entry. Suggested fix: Add a Release Notes heading and one list entry. Use - N/A for non-user-facing work. |
A colocated repo must not use git worktrees: they change refs behind jj. The worktree target now creates a jj workspace when .jj exists and a git worktree otherwise. The worktree-done target forgets the workspace after an unmerged-change check, with the same git path as the fallback. Co-Authored-By: Martin Zeman <N4M3Z@users.noreply.github.com>
Runeseer review — cleanLooks good. The head commit is unchanged since the last review, and both previously raised issues in the
No open findings · Reviewed |
|
@cursor review |
Bugbot is paused — on-demand spend limit reachedBugbot uses usage-based billing for this team and has hit its on-demand spend limit. A team admin can raise the spend limit in the Cursor dashboard, or wait for the next billing cycle to continue. |
The worktree target creates an identity worktree; nothing removed one. The worktree-done target verifies a clean tree and a fully merged branch, then removes the worktree and deletes the branch.
ignore:spec: the target automates the documented cleanup step and changes no check.
Release Notes
make worktreein colocated repositories.make worktree-doneto remove merged worktrees or workspaces after cleanliness checks.