Add check for kms permissions for EBS Encryption to doctor command - #24
Open
NickLavrov wants to merge 2 commits into
Open
Add check for kms permissions for EBS Encryption to doctor command#24NickLavrov wants to merge 2 commits into
NickLavrov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deployed a RunsOn Flex stack with EbsEncryptionKey unset. Because our AWS account has EBS encryption by default enabled, EC2 still encrypted volumes with the account default KMS key — but -flex-role did not have permissions to use that key, so runner instances failed to launch. This was hard to spot from existing doctor output.
This PR adds a Flex-only check to roc stack doctor that resolves the EBS encryption key in use and verifies the flex role can access it.
Key resolution
IAM validation
Changes
Test plan
[ x ] go test ./internal/cli/ -run 'Doctor|FlexRole|EBS|IAM|KMS|ResolveEBS' -v
[ x ] roc stack doctor --stack against a Flex stack with account default EBS encryption and confirm the check passes or reports missing KMS permissions
Confirm Fleet stacks skip the check with ⏭️ (please test this with a fleet deployment if possible)
[ x ] Confirm failure output lists the resolved key (e.g. alias/aws/ebs) and missing actions when permissions are incomplete