PLASMA-7867: add curvature in tail in beta Popover, Tooltip by shuga2704 · Pull Request #3000 · salute-developers/plasma

shuga2704 · 2026-07-29T09:53:17Z

Core

Tooltip, Popover (Beta)

добавлена возможность конфигурации tail компонентов

What/why changed

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @salutejs/plasma-asdk@0.385.0-canary.3000.30610297220.0
npm install @salutejs/plasma-b2c@1.627.0-canary.3000.30610297220.0
npm install @salutejs/plasma-colors@0.17.0-canary.3000.30610297220.0
npm install @salutejs/plasma-core@1.234.0-canary.3000.30610297220.0
npm install @salutejs/plasma-giga@0.354.0-canary.3000.30610297220.0
npm install @salutejs/plasma-homeds@0.354.0-canary.3000.30610297220.0
npm install @salutejs/plasma-hope@1.381.0-canary.3000.30610297220.0
npm install @salutejs/plasma-icons@1.244.0-canary.3000.30610297220.0
npm install @salutejs/plasma-new-hope@0.371.0-canary.3000.30610297220.0
npm install @salutejs/plasma-tokens@1.146.0-canary.3000.30610297220.0
npm install @salutejs/plasma-tokens-b2b@1.60.0-canary.3000.30610297220.0
npm install @salutejs/plasma-tokens-b2c@0.71.0-canary.3000.30610297220.0
npm install @salutejs/plasma-tokens-core@0.8.0-canary.3000.30610297220.0
npm install @salutejs/plasma-tokens-web@1.75.0-canary.3000.30610297220.0
npm install @salutejs/plasma-typo@0.48.0-canary.3000.30610297220.0
npm install @salutejs/plasma-web@1.629.0-canary.3000.30610297220.0
npm install @salutejs/sdds-bizcom@0.359.0-canary.3000.30610297220.0
npm install @salutejs/sdds-cs@0.363.0-canary.3000.30610297220.0
npm install @salutejs/sdds-dfa@0.357.0-canary.3000.30610297220.0
npm install @salutejs/sdds-finai@0.350.0-canary.3000.30610297220.0
npm install @salutejs/sdds-insol@0.354.0-canary.3000.30610297220.0
npm install @salutejs/sdds-insol-next@0.354.0-canary.3000.30610297220.0
npm install @salutejs/sdds-netology@0.358.0-canary.3000.30610297220.0
npm install @salutejs/sdds-os@0.29.0-canary.3000.30610297220.0
npm install @salutejs/sdds-platform-ai@0.358.0-canary.3000.30610297220.0
npm install @salutejs/sdds-sbcom@0.359.0-canary.3000.30610297220.0
npm install @salutejs/sdds-scan@0.357.0-canary.3000.30610297220.0
npm install @salutejs/sdds-serv@0.358.0-canary.3000.30610297220.0
npm install @salutejs/core-themes@0.36.0-canary.3000.30610297220.0
npm install @salutejs/plasma-themes@0.58.0-canary.3000.30610297220.0
npm install @salutejs/sdds-themes@0.72.0-canary.3000.30610297220.0
npm install @salutejs/sdds-api-tests@0.16.0-canary.3000.30610297220.0
npm install @salutejs/plasma-cy-utils@0.164.0-canary.3000.30610297220.0
npm install @salutejs/plasma-sb-utils@0.235.0-canary.3000.30610297220.0
npm install @salutejs/plasma-tokens-utils@0.56.0-canary.3000.30610297220.0
# or 
yarn add @salutejs/plasma-asdk@0.385.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-b2c@1.627.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-colors@0.17.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-core@1.234.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-giga@0.354.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-homeds@0.354.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-hope@1.381.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-icons@1.244.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-new-hope@0.371.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-tokens@1.146.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-tokens-b2b@1.60.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-tokens-b2c@0.71.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-tokens-core@0.8.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-tokens-web@1.75.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-typo@0.48.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-web@1.629.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-bizcom@0.359.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-cs@0.363.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-dfa@0.357.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-finai@0.350.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-insol@0.354.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-insol-next@0.354.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-netology@0.358.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-os@0.29.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-platform-ai@0.358.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-sbcom@0.359.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-scan@0.357.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-serv@0.358.0-canary.3000.30610297220.0
yarn add @salutejs/core-themes@0.36.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-themes@0.58.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-themes@0.72.0-canary.3000.30610297220.0
yarn add @salutejs/sdds-api-tests@0.16.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-cy-utils@0.164.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-sb-utils@0.235.0-canary.3000.30610297220.0
yarn add @salutejs/plasma-tokens-utils@0.56.0-canary.3000.30610297220.0

Summary by CodeRabbit

Enhancements
- Improved Popover and Tooltip tails with more accurate placement-aware positioning and rotation.
- Introduced configurable tail geometry (width, height, and curvature) across supported sizes.
Bug Fixes
- Prevented brief visual display by hiding the overlay content until positioning is fully calculated.
Theme/Examples
- Updated Popover and Tooltip size variants in example and theme configurations to use the new tail token values.

coderabbitai · 2026-07-29T09:53:24Z

📝 Walkthrough

Walkthrough

Popover and Tooltip replace FloatingArrow with token-driven custom tails. Floating UI placement and arrow middleware data determine tail offsets and styles, while component configurations define tail geometry for supported sizes and themes.

Changes

Custom popover and tooltip tails

Layer / File(s)	Summary
Tail contracts and geometry `packages/plasma-new-hope/src/components/_beta/Popover/Popover.tokens.ts`, `Popover.styles.ts`, `Tooltip/Tooltip.tokens.ts`, `Tooltip.styles.ts`	Popover and Tooltip add tail tokens and styled components that size, rotate, position, and clip the tail shape by side.
Placement-aware tail positioning `packages/plasma-new-hope/src/components/_beta/Popover/Popover.tsx`, `Tooltip/Tooltip.tsx`	Floating UI middleware measures the rendered tail, derives placement and arrow coordinates, controls root visibility, and renders the custom tail.
Theme tail geometry `packages/plasma-new-hope/src/examples/components/_beta/`, `packages/sdds-cs/src/components/_beta/`, `packages/sdds-finai/src/components/_beta/`, `packages/sdds-sbcom/src/components/_beta/`	Popover and Tooltip size variations define tail width, height, and curvature values.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Sequence Diagram(s)

sequenceDiagram
  participant PopoverTooltip
  participant FloatingUI
  participant Tail
  PopoverTooltip->>FloatingUI: Read placement and arrow middleware data
  FloatingUI-->>PopoverTooltip: Return placement and arrow coordinates
  PopoverTooltip->>Tail: Pass side, ref, and computed style
  Tail-->>PopoverTooltip: Render the positioned tail

Possibly related PRs

salute-developers/plasma#2956: Changes Tooltip Floating UI middleware in the same positioning pipeline.
salute-developers/plasma#2996: Adjusts Popover and Tooltip arrow positioning logic.

Suggested labels: sdds-beta, sdds-sbcom, sdds-cs, sdds-finai

Suggested reviewers: irinkv, titankuzmich, yakutoc

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: adding curvature to beta Popover and Tooltip tails.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Fix failing CI checks

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch plasma-7867

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-07-29T09:59:25Z

Theme Builder app deployed!

https://plasma.sberdevices.ru/pr/plasma-theme-builder-pr-3000/

github-actions · 2026-07-29T11:24:39Z

Documentation preview deployed!

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/plasma-new-hope/src/components/_beta/Popover/Popover.tsx`:
- Around line 107-120: The offset callbacks in Popover.tsx lines 107-120 and
Tooltip.tsx lines 83-96 must react when the Tail geometry changes, not only when
outerOffset or hasTail changes. Add the Tail’s size/geometry as a dependency or
observe its dimensions and invoke Floating UI’s update so repositioning occurs
while the component remains open.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e3b2c5fe-a678-482a-a504-12ab9f498501

📥 Commits

Reviewing files that changed from the base of the PR and between befdf96 and dada089.

📒 Files selected for processing (17)

packages/plasma-new-hope/src/components/_beta/Popover/Popover.styles.ts
packages/plasma-new-hope/src/components/_beta/Popover/Popover.tokens.ts
packages/plasma-new-hope/src/components/_beta/Popover/Popover.tsx
packages/plasma-new-hope/src/components/_beta/Tooltip/Tooltip.styles.ts
packages/plasma-new-hope/src/components/_beta/Tooltip/Tooltip.tokens.ts
packages/plasma-new-hope/src/components/_beta/Tooltip/Tooltip.tsx
packages/plasma-new-hope/src/examples/components/_beta/Popover/Popover.closeInner.config.ts
packages/plasma-new-hope/src/examples/components/_beta/Popover/Popover.closeNone.config.ts
packages/plasma-new-hope/src/examples/components/_beta/Tooltip/Tooltip.config.ts
packages/sdds-cs/src/components/_beta/Popover/Popover.closeInner.config.ts
packages/sdds-cs/src/components/_beta/Popover/Popover.closeNone.config.ts
packages/sdds-cs/src/components/_beta/Tooltip/Tooltip.config.ts
packages/sdds-finai/src/components/_beta/Popover/Popover.closeInner.config.ts
packages/sdds-finai/src/components/_beta/Popover/Popover.closeNone.config.ts
packages/sdds-finai/src/components/_beta/Tooltip/Tooltip.config.ts
packages/sdds-sbcom/src/components/_beta/Popover/Popover.config.ts
packages/sdds-sbcom/src/components/_beta/Tooltip/Tooltip.config.ts

github-actions · 2026-08-05T13:48:27Z

This PR is included in version:

@salutejs/plasma-asdk@0.386.0
@salutejs/plasma-b2c@1.628.0
@salutejs/plasma-colors@0.17.0
@salutejs/plasma-core@1.235.0
@salutejs/plasma-giga@0.355.0
@salutejs/plasma-homeds@0.355.0
@salutejs/plasma-hope@1.382.0
@salutejs/plasma-icons@1.244.0
@salutejs/plasma-new-hope@0.372.0
@salutejs/plasma-tokens@1.146.0
@salutejs/plasma-tokens-b2b@1.60.0
@salutejs/plasma-tokens-b2c@0.71.0
@salutejs/plasma-tokens-core@0.8.0
@salutejs/plasma-tokens-web@1.75.0
@salutejs/plasma-typo@0.48.0
@salutejs/plasma-web@1.630.0
@salutejs/sdds-bizcom@0.360.0
@salutejs/sdds-cs@0.364.0
@salutejs/sdds-dfa@0.358.0
@salutejs/sdds-finai@0.351.0
@salutejs/sdds-insol@0.355.0
@salutejs/sdds-insol-next@0.354.0
@salutejs/sdds-netology@0.359.0
@salutejs/sdds-os@0.30.0
@salutejs/sdds-platform-ai@0.359.0
@salutejs/sdds-sbcom@0.360.0
@salutejs/sdds-scan@0.358.0
@salutejs/sdds-serv@0.359.0
@salutejs/core-themes@0.36.0
@salutejs/plasma-themes@0.58.0
@salutejs/sdds-themes@0.73.0
@salutejs/sdds-api-tests@0.17.0
@salutejs/plasma-cy-utils@0.165.0
@salutejs/plasma-sb-utils@0.236.0
@salutejs/plasma-tokens-utils@0.56.0

shuga2704 self-assigned this Jul 29, 2026

shuga2704 added the changelog-skip Exclude pull request changes from changelog label Jul 29, 2026

shuga2704 temporarily deployed to internal July 29, 2026 09:53 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7867 branch from 80feec5 to 94d7a1a Compare July 29, 2026 13:49

shuga2704 temporarily deployed to internal July 29, 2026 13:50 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7867 branch from 94d7a1a to d6431d7 Compare July 29, 2026 13:56

shuga2704 temporarily deployed to internal July 29, 2026 13:56 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7867 branch from d6431d7 to c20caef Compare July 29, 2026 14:22

shuga2704 temporarily deployed to internal July 29, 2026 14:22 — with GitHub Actions Inactive

shuga2704 changed the title ~~PLASMA-7867: add renderTail prop~~ PLASMA-7867: add curvature in tail in beta Popover, Tooltip Jul 29, 2026

shuga2704 force-pushed the plasma-7867 branch from c20caef to ae86c98 Compare July 29, 2026 14:24

shuga2704 temporarily deployed to internal July 29, 2026 14:24 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal July 29, 2026 14:25 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7867 branch from ae86c98 to 31d62fe Compare July 29, 2026 15:31

shuga2704 temporarily deployed to internal July 29, 2026 15:31 — with GitHub Actions Inactive

shuga2704 temporarily deployed to internal July 29, 2026 15:35 — with GitHub Actions Inactive

coderabbitai Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread packages/plasma-new-hope/src/components/_beta/Popover/Popover.tsx

shuga2704 force-pushed the plasma-7867 branch from dada089 to d02a615 Compare July 30, 2026 08:26

shuga2704 temporarily deployed to internal July 30, 2026 08:26 — with GitHub Actions Inactive

shuga2704 force-pushed the plasma-7867 branch from d02a615 to f452ab0 Compare July 30, 2026 08:32

shuga2704 temporarily deployed to internal July 30, 2026 08:32 — with GitHub Actions Inactive

Irinkv approved these changes Jul 30, 2026

View reviewed changes

shuga2704 force-pushed the plasma-7867 branch from f452ab0 to ef41acf Compare July 31, 2026 06:39

shuga2704 temporarily deployed to internal July 31, 2026 06:39 — with GitHub Actions Inactive

shuga2704 requested review from TitanKuzmich, Yakutoc and angirb July 31, 2026 06:53

TitanKuzmich approved these changes Jul 31, 2026

View reviewed changes

angirb approved these changes Aug 3, 2026

View reviewed changes

Yakutoc added sdds-sbcom sdds-beta and removed changelog-skip Exclude pull request changes from changelog labels Aug 4, 2026

TitanKuzmich force-pushed the plasma-7867 branch from ef41acf to feb5325 Compare August 4, 2026 07:51

TitanKuzmich had a problem deploying to internal August 4, 2026 07:51 — with GitHub Actions Error

TitanKuzmich temporarily deployed to internal August 4, 2026 07:51 — with GitHub Actions Inactive

feat(beta): add curvature in tail in beta Popover, Tooltip

6084c04

TitanKuzmich force-pushed the plasma-7867 branch from feb5325 to 6084c04 Compare August 4, 2026 07:56

TitanKuzmich temporarily deployed to internal August 4, 2026 07:56 — with GitHub Actions Inactive

Yakutoc merged commit d14a064 into dev Aug 4, 2026
66 of 67 checks passed

Yakutoc deleted the plasma-7867 branch August 4, 2026 10:01

Salute-Eva mentioned this pull request Aug 4, 2026

Release by 05.08.2026 #3016

Merged

Navigation Menu

Uh oh!

PLASMA-7867: add curvature in tail in beta Popover, Tooltip - #3000

PLASMA-7867: add curvature in tail in beta Popover, Tooltip#3000
Yakutoc merged 1 commit into
devfrom
plasma-7867

shuga2704 commented Jul 29, 2026 •

edited by Yakutoc

Loading

Uh oh!

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

github-actions Bot commented Jul 29, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

shuga2704 commented Jul 29, 2026 • edited by Yakutoc Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core

Tooltip, Popover (Beta)

What/why changed

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

github-actions Bot commented Jul 29, 2026

Uh oh!

github-actions Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

shuga2704 commented Jul 29, 2026 •

edited by Yakutoc

Loading

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading

github-actions Bot commented Jul 29, 2026 •

edited

Loading