Skip to content

docs: drop stale keep_files / dashboard-config comments#401

Open
max-parke-scale wants to merge 1 commit into
nextfrom
cc/drop-keep-files-comment
Open

docs: drop stale keep_files / dashboard-config comments#401
max-parke-scale wants to merge 1 commit into
nextfrom
cc/drop-keep-files-comment

Conversation

@max-parke-scale

@max-parke-scale max-parke-scale commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

The keep_files comments in pyproject.toml and adk/pyproject.toml, plus the matching claim in adk/README.md, were incorrect — this repo doesn't use keep_files at all. Stainless codegen never generates adk/**, agentex/lib/*, or agentex/protocol/* (no codegen header on those files), so they're never touched and need no protection. Hand-authored edits that do live in codegen-managed files (pyproject.toml, README.md, the locks) are reconciled by Stainless's custom-code 3-way merge, not keep_files.

  • root pyproject.toml: drop the now-completed "Stainless dashboard config must…" TODO (incl. the false keep_files line)
  • adk/pyproject.toml: drop the keep_files preservation note
  • adk/README.md: correct the sentence to state the real reason (adk/ is outside the generated surface)

Comment/doc-only — no behavior change.

🧑‍💻🤖 — posted via Claude Code

Greptile Summary

This PR removes stale comments referencing keep_files and a Stainless dashboard TODO from pyproject.toml, adk/pyproject.toml, and adk/README.md. It corrects the documentation to reflect that adk/** is simply outside the Stainless-generated surface and therefore never touched by codegen — no keep_files entry is needed.

  • pyproject.toml: Drops a now-completed TODO block that incorrectly described pending dashboard configuration including a keep_files entry.
  • adk/pyproject.toml and adk/README.md: Remove/correct the false claim that adk/** is preserved via keep_files; the accurate reason (outside generated surface) is now documented.

Confidence Score: 5/5

Pure comment/documentation cleanup with no code changes — safe to merge.

All three files have only comment or prose deletions/corrections. No logic, configuration, or runtime behaviour is touched. The removed text was already inaccurate (the repo doesn't use keep_files), so deleting it strictly improves documentation accuracy.

No files require special attention.

Important Files Changed

Filename Overview
pyproject.toml Removes stale 4-line TODO comment block about Stainless dashboard configuration and keep_files; no functional change.
adk/pyproject.toml Removes 3-line comment asserting adk/ must be preserved via keep_files; no functional change.
adk/README.md Corrects one sentence: replaces the keep_files explanation with the accurate statement that adk/** is outside the generated surface.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Stainless Codegen] -->|generates| B[agentex-client\npyproject.toml / REST surface]
    A -->|never touches| C[adk/**\nagentex-sdk]
    B -->|runtime dep| C
    C --> D[agentex.lib.*\nagentex.protocol.*\nFastACP / Temporal / LLM]
    B --> E[agentex.__init__\nagentex._*\nagentex.types / resources]

    style C fill:#d4edda,stroke:#28a745
    style B fill:#cce5ff,stroke:#004085
Loading

Reviews (2): Last reviewed commit: "docs: drop stale keep_files / dashboard-..." | Re-trigger Greptile

These comments instructed adding adk/** to keep_files, but the repo doesn't use keep_files. Stainless codegen never generates adk/**, agentex/lib/*, or agentex/protocol/* (no codegen header), so those paths are never touched and need no protection; codegen-managed files (pyproject/README/locks) are handled by custom-code 3-way merge instead. The dashboard-config TODO is also done. Corrects the same false claim in adk/README.md.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@max-parke-scale max-parke-scale force-pushed the cc/drop-keep-files-comment branch from 70476f3 to e20f3cb Compare June 11, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant