docs: drop stale keep_files / dashboard-config comments#401
Open
max-parke-scale wants to merge 1 commit into
Open
docs: drop stale keep_files / dashboard-config comments#401max-parke-scale wants to merge 1 commit into
max-parke-scale wants to merge 1 commit into
Conversation
These comments instructed adding adk/** to keep_files, but the repo doesn't use keep_files. Stainless codegen never generates adk/**, agentex/lib/*, or agentex/protocol/* (no codegen header), so those paths are never touched and need no protection; codegen-managed files (pyproject/README/locks) are handled by custom-code 3-way merge instead. The dashboard-config TODO is also done. Corrects the same false claim in adk/README.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
70476f3 to
e20f3cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
keep_filescomments inpyproject.tomlandadk/pyproject.toml, plus the matching claim inadk/README.md, were incorrect — this repo doesn't usekeep_filesat all. Stainless codegen never generatesadk/**,agentex/lib/*, oragentex/protocol/*(no codegen header on those files), so they're never touched and need no protection. Hand-authored edits that do live in codegen-managed files (pyproject.toml,README.md, the locks) are reconciled by Stainless's custom-code 3-way merge, notkeep_files.pyproject.toml: drop the now-completed "Stainless dashboard config must…" TODO (incl. the falsekeep_filesline)adk/pyproject.toml: drop thekeep_filespreservation noteadk/README.md: correct the sentence to state the real reason (adk/is outside the generated surface)Comment/doc-only — no behavior change.
🧑💻🤖 — posted via Claude Code
Greptile Summary
This PR removes stale comments referencing
keep_filesand a Stainless dashboard TODO frompyproject.toml,adk/pyproject.toml, andadk/README.md. It corrects the documentation to reflect thatadk/**is simply outside the Stainless-generated surface and therefore never touched by codegen — nokeep_filesentry is needed.pyproject.toml: Drops a now-completed TODO block that incorrectly described pending dashboard configuration including akeep_filesentry.adk/pyproject.tomlandadk/README.md: Remove/correct the false claim thatadk/**is preserved viakeep_files; the accurate reason (outside generated surface) is now documented.Confidence Score: 5/5
Pure comment/documentation cleanup with no code changes — safe to merge.
All three files have only comment or prose deletions/corrections. No logic, configuration, or runtime behaviour is touched. The removed text was already inaccurate (the repo doesn't use
keep_files), so deleting it strictly improves documentation accuracy.No files require special attention.
Important Files Changed
keep_files; no functional change.adk/must be preserved viakeep_files; no functional change.keep_filesexplanation with the accurate statement thatadk/**is outside the generated surface.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[Stainless Codegen] -->|generates| B[agentex-client\npyproject.toml / REST surface] A -->|never touches| C[adk/**\nagentex-sdk] B -->|runtime dep| C C --> D[agentex.lib.*\nagentex.protocol.*\nFastACP / Temporal / LLM] B --> E[agentex.__init__\nagentex._*\nagentex.types / resources] style C fill:#d4edda,stroke:#28a745 style B fill:#cce5ff,stroke:#004085Reviews (2): Last reviewed commit: "docs: drop stale keep_files / dashboard-..." | Re-trigger Greptile