Skip to content

feat(object): add support for 's3-endpoint' to bucket cmds - #5636

Open
pypaut wants to merge 66 commits into
scaleway:mainfrom
pypaut:feat/s3-endpoint
Open

feat(object): add support for 's3-endpoint' to bucket cmds#5636
pypaut wants to merge 66 commits into
scaleway:mainfrom
pypaut:feat/s3-endpoint

Conversation

@pypaut

@pypaut pypaut commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #5568.

This PR depends on scaleway/scaleway-sdk-go#3100.

Release note for CHANGELOG:

Add an `s3-endpoint` flag to the bucket commands
Add support for `s3_endpoint` specified in the configuration profile

@pypaut pypaut self-assigned this Jun 4, 2026
@pypaut pypaut changed the title feat(object): add 's3-endpoint' to bucket cmds feat(object): add 's3-endpoint' flag to bucket cmds Jun 4, 2026
@codecov-commenter

codecov-commenter commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.90939% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.91%. Comparing base (a2a4017) to head (57b7aa0).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
core/testing_recorder.go 7.69% 12 Missing ⚠️
internal/namespaces/object/v1/s3_helpers.go 88.57% 8 Missing ⚠️
internal/namespaces/object/v1/custom_bucket.go 96.25% 3 Missing ⚠️
internal/namespaces/config/commands.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5636      +/-   ##
==========================================
+ Coverage   50.80%   50.91%   +0.11%     
==========================================
  Files         359      359              
  Lines       82260    82471     +211     
==========================================
+ Hits        41790    41992     +202     
- Misses      40470    40479       +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pypaut
pypaut force-pushed the feat/s3-endpoint branch from 8934206 to fab68ff Compare June 8, 2026 14:39
@pypaut
pypaut marked this pull request as ready for review June 8, 2026 14:40
@pypaut
pypaut requested review from a team and remyleone as code owners June 8, 2026 14:40
@pypaut
pypaut marked this pull request as draft June 8, 2026 15:15
@pypaut

pypaut commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Doesn't build because it relies on an SDK version that is not live yet.

@pypaut pypaut changed the title feat(object): add 's3-endpoint' flag to bucket cmds feat(object): add support for 's3-endpoint' to bucket cmds Jun 9, 2026
@pypaut pypaut added the priority:medium Improvements that are not the main priority label Jun 18, 2026
@pypaut
pypaut force-pushed the feat/s3-endpoint branch from 78ae589 to d02bb3f Compare June 29, 2026 16:32
@pypaut
pypaut force-pushed the feat/s3-endpoint branch from 671b699 to 49afaa9 Compare July 31, 2026 14:50
@pypaut

pypaut commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Broken because depends on scaleway/scaleway-sdk-go#3253

@pypaut
pypaut force-pushed the feat/s3-endpoint branch from 9f4a2d3 to fcc5c67 Compare August 6, 2026 10:25
@pypaut
pypaut marked this pull request as ready for review August 7, 2026 07:32
@pypaut
pypaut requested a review from a team as a code owner August 7, 2026 07:32
Comment thread internal/namespaces/object/v1/custom_bucket.go Outdated
Comment thread internal/namespaces/object/v1/custom_bucket.go
Comment thread internal/namespaces/object/v1/custom_bucket.go
Comment thread internal/namespaces/object/v1/custom_bucket_cors.go
Comment thread internal/namespaces/object/v1/custom_bucket.go Outdated
Comment thread internal/namespaces/object/v1/s3configfile.go Outdated
Comment thread internal/namespaces/object/v1/s3_helpers.go
Comment thread internal/namespaces/object/v1/custom_bucket.go Outdated
Comment thread internal/namespaces/object/v1/custom_bucket.go
Comment thread internal/namespaces/object/v1/custom_bucket.go
Comment thread internal/namespaces/object/v1/custom_bucket.go Outdated
@estellesoulard

Copy link
Copy Markdown
Contributor

If it's realistic, could some tests be added on each impacted call using the new flags to confirm the new behaviour?

@pypaut
pypaut requested a review from estellesoulard August 31, 2026 12:55
@pypaut
pypaut requested a review from remyleone September 1, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority:medium Improvements that are not the main priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for overriding endpoints for object storage

4 participants