Infer fig from ax in show() instead of requiring it#655
Merged
Conversation
Closes #625, #579. When a list of `Axes` is passed to `pl.show()`, infer the figure via `ax[0].get_figure()` rather than raising when `fig=` is omitted, mirroring the single-axis path. Also normalize a single-element `Sequence` of axes in the single-panel branch (previously left `fig` unbound and tripped a downstream `isinstance` assert) and emit the existing `fig=` deprecation warning for the multi-axis path too.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #655 +/- ##
==========================================
+ Coverage 77.04% 77.07% +0.02%
==========================================
Files 11 11
Lines 3276 3280 +4
Branches 772 774 +2
==========================================
+ Hits 2524 2528 +4
- Misses 453 454 +1
+ Partials 299 298 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pl.show(ax=[...])now infersfigfromax[0].get_figure()instead of raising whenfig=is omitted, mirroring the single-axis path.Sequenceof axes (previously leftfigunbound and tripped a downstreamisinstance(ax, Axes)assert).fig=deprecation warning now also fires when paired with a list of axes.Closes #625. Closes #579.