Implement support for floating output paths#375
Open
poly2it wants to merge 3 commits into
Open
Conversation
Author
|
I pushed two additional commits to resolve an issue which was only made evident after initial support was implemented. In Nix 2.34, See this document in the Nix repository for an explanation to the changes: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I took a shot at resolving the issues with ca-derivations (#164) since I use them quite frequently. This resolves the issues I was having, but you might want to test the changes further. The changes were implemented with help from Claude Opus 4.7. If this is an issue, I would like to make you aware of it.
This branch keeps the user-facing API unchanged. A Nix transformation, applied in both flake and non-flake eval modes, walks
nodes.*.profiles.*. Whenpathevaluates to a derivation, it is transformed such thatpathbecomesoutPathand a siblingdrvPathis added. The binary picks up the newdrvPathfield onProfileSettingsand builds the.drvdirectly. The realised output is then resolved by callingnix path-info <drv>^outagainst the local or remote store. That resolved path is used throughout copy, activate, confirm, and revoke, so no stage falls back to the eval-time placeholder.