Skip to content

revert: "feat: [PR-1797] add sf migrate command and Rust CLI migration banner (#266)"#267

Merged
sigmachirality merged 1 commit into
mainfrom
indent-2026-05-26-revert-migrate-banner
May 27, 2026
Merged

revert: "feat: [PR-1797] add sf migrate command and Rust CLI migration banner (#266)"#267
sigmachirality merged 1 commit into
mainfrom
indent-2026-05-26-revert-migrate-banner

Conversation

@sigmachirality
Copy link
Copy Markdown
Member

@sigmachirality sigmachirality commented May 27, 2026

Summary

Reverts #266 (commit 06230a2).

Motivation

The Rust CLI install script at cli.sfcompute.com does not actually create the promised sf-old fallback (repro: curl -fsSL https://sfcompute.com/cli/install | bash followed by sf migrate leaves no working sf-old on disk). That means anyone who follows the new migration banner or runs sf migrate loses access to the legacy CLI entirely, with no escape hatch.

Pulling the banner + sf migrate command until the install script is fixed.

Testing

  • Cut a release from main after this merges so the prompt stops shipping to users.

Open in Indent

…on banner (#266)"

This reverts commit 06230a2.

The Rust CLI install script at cli.sfcompute.com does not actually
create the promised `sf-old` fallback, so users who follow the
migration banner / `sf migrate` lose access to the legacy CLI. Reverting
the banner + `sf migrate` command until that install script is fixed.

Generated with [Indent](https://indent.com)
Co-Authored-By: Indent <noreply@indent.com>
@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented May 27, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  src/lib/upgrade.ts  36% smaller
  src/checkVersion.ts  17% smaller
  src/index.ts  16% smaller
  install.sh Unsupported file format
  src/lib/migrate.ts  0% smaller

@indent
Copy link
Copy Markdown
Contributor

indent Bot commented May 27, 2026

PR Summary

Reverts commit 06230a2 (the sf migrate command and Rust-CLI migration banner) because the Rust installer at cli.sfcompute.com does not actually create the promised sf-old fallback — meaning anyone who followed the banner or ran sf migrate lost access to the legacy CLI. The revert is mechanically clean: a git diff of the head branch against the parent of the original feature commit on the five touched files is empty, and a repo-wide grep for the removed symbols/env vars turns up no stragglers.

  • install.sh: drops the SF_CLI_BINARY_NAME / SF_CLI_TARGET_DIR env-var overrides and the "skip PATH nudge on in-place upgrade" branch; reverts to hardcoded sf in ~/.local/bin.
  • src/checkVersion.ts: reverts checkVersion() from Promise<boolean> back to Promise<void> (only caller was updated in the same PR).
  • src/index.ts: removes the registerMigrate registration, the showMigrateBanner fallback, and the argv[2] === "migrate" auto-upgrade opt-out.
  • src/lib/migrate.ts: deleted in full (124 lines).
  • src/lib/upgrade.ts: drops the now-unused basename/dirname imports and stops forwarding SF_CLI_TARGET_DIR/SF_CLI_BINARY_NAME to the install script.

Note for the author: this revert lands at package.json version 0.32.2, which is the version the original feature shipped under — a follow-up release: v0.32.3 commit will be needed for the revert to actually reach users via the auto-upgrade flow.

Issues

No issues found.

CI Checks

All CI checks passed on 9b7070e.

@sigmachirality sigmachirality added the indent label May 27, 2026 — with indent
@capy-ai
Copy link
Copy Markdown

capy-ai Bot commented May 27, 2026

Capy auto-review is paused for this organization because the monthly auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews.

@sigmachirality sigmachirality changed the title Revert "feat: [PR-1797] add sf migrate command and Rust CLI migration banner (#266)" revert: "feat: [PR-1797] add sf migrate command and Rust CLI migration banner (#266)" May 27, 2026
@sigmachirality sigmachirality merged commit 34eddda into main May 27, 2026
2 checks passed
@sigmachirality sigmachirality deleted the indent-2026-05-26-revert-migrate-banner branch May 27, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant