fix: EOF spin loop in client->shell & pager disp#359
Merged
ethanpailes merged 1 commit intomasterfrom May 1, 2026
Merged
Conversation
maxhbooth
approved these changes
May 1, 2026
This patch fixes a couple of EOF spin loops in the client->shell thread and in the pager display thread. In both cases, we were continuing rather than bailing on EOF. This should prevent CPU pegging.
ethanpailes
force-pushed
the
fix-shell-to-client-EOF-spin
branch
from
dce4f5b to
c8344e6
Compare
Contributor
Author
|
The mac tests are spewing 403s trying to fetch packages. I think there is infra issue. I'm going to merge through it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link
n/a
AI Policy Ack
Ack
This PR was:
Gemini found this issue for me when I asked it to try to deflake some tests. I wrote the fix and vibed the tests for it.
Description
This patch fixes a couple of EOF spin loops in the client->shell thread and in the pager display thread. In both cases, we were continuing rather than bailing on EOF. This should prevent CPU pegging.