fix(deps): close the seven Dependabot alerts - #13
Merged
Conversation
- js-yaml 4.1 β 4.3.1 (high): merge-key chains force quadratic CPU. Direct dependency, used to parse .github/agent.yml β which arrives from a repository, so it is reachable input. - postcss β 8.5.25 (high, both manifests): path traversal in source-map auto-loading. - protobufjs β 7.6.5: infinite loop parsing .proto options. - react-router-dom 6.30 β 7.18.2 (medium Γ3): the 6.x line has no patch for the alert, so this is the major bump rather than a version pick. The v7 move is API-compatible with what the site uses β BrowserRouter, Routes, Route, Link, NavLink, Navigate, useSearchParams, useLocation, useNavigate, useParams. Typecheck, build, and a browser pass over the dashboard all clean; nav links still carry filters across pages. Two things deliberately not done here: - react-router 7.18.2 carries GHSA-qwww-vcr4-c8h2 (>=7.12.0 <8.3.0), and 8.3.0 does not exist yet. npm offers a "fix" of 7.11.0, which is below 7.18.0 and so reintroduces the alert this commit closes. The advisory is an RSC-mode CSRF bypass; this is a client-only SPA with no framework mode, no server actions and no RSC β there is no react-router.config and nothing imports react-router/rsc. Staying on the latest is the better of the two available positions. - The 21 remaining moderate advisories are all probot's OpenTelemetry and Sentry chain. None are in GitHub's alert list, and the only fix npm offers is probot@14 β a major bump of the webhook framework, which does not belong in a dependency patch.
|
π ShipIT Forge is running a code + security review on this PRβ¦ I'll post my review shortly. |
π ShipIT Forge reviewed this PR β π¬ commented (no blocking issues)0 finding(s) (0 security). See the review above for inline details and suggested fixes. |
There was a problem hiding this comment.
ShipIT Forge review
β No blocking issues found. I reviewed the changed files and ran:
- π‘οΈ Security checks β SSRF, injection (SQL/command/template), broken auth/authz, hardcoded secrets, unsafe deserialization, path traversal, weak crypto.
- π§ Code review β correctness, error handling, missing tests, clarity.
Nothing to flag. This is a comment, not an approval β ShipIT Forge never approves PRs; a human reviewer should approve and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes every alert GitHub currently reports on
main: 3 high, 4 moderate.js-yaml.github/agent.ymlβ which arrives from a repository, so it is reachable input.postcssprotobufjs.protooptions.react-router-domOn the react-router major
API-compatible with everything the site uses:
BrowserRouter,Routes,Route,Link,NavLink,Navigate,useSearchParams,useLocation,useNavigate,useParams. Verified by typecheck, production build, and a browser pass over every dashboard page β nav links still carry filters across pages.Two things deliberately left alone
react-router7.18.2 carries GHSA-qwww-vcr4-c8h2 (>=7.12.0 <8.3.0), and 8.3.0 is not published yet. npm offers a "fix" of 7.11.0 β which is below 7.18.0 and therefore reintroduces the alert this PR closes. The advisory is an RSC-mode CSRF bypass; this is a client-only SPA with no framework mode, no server actions and no RSC (noreact-router.config, nothing importsreact-router/rsc). Staying on the latest is the better of the two available positions, and this should be revisited when 8.3.0 ships.The 21 remaining moderate
npm auditfindings are all probot's OpenTelemetry and Sentry chain. None are in GitHub's alert list, and the only fix npm offers isprobot@14β a major bump of the webhook framework, which does not belong in a dependency patch.Verification
npm testβ 546 passingnpx tsc --noEmitβ clean, both packagesnpm run buildandvite buildβ clean/dashboard,/runs,/tools,/events,/findingsRaised as a PR rather than a direct push, so the
teststatus check runs before this reachesmain.